Page MenuHomeFreeBSD
Differential D11671

Fix test timeout: common.speculation.t_dtrace_contrib.tst_NoSpecBuffer_d
ClosedPublic
Actions

Authored by lwhsu on Jul 20 2017, 5:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 4:58 PM
Unknown Object (File)
Wed, Oct 2, 10:13 AM
Unknown Object (File)
Sep 28 2024, 9:16 AM
Unknown Object (File)
Sep 21 2024, 12:37 PM
Unknown Object (File)
Sep 17 2024, 9:48 AM
Unknown Object (File)
Sep 8 2024, 2:41 PM
Unknown Object (File)
Sep 8 2024, 8:56 AM
Unknown Object (File)
Sep 8 2024, 6:57 AM
View All 67 Files
Subscribers
imp

Details

Reviewers
gnn
markj
ngie
Commits
rS321465: Add a simple script which calls open(2) and others to generate events for
Summary

This test timeout on a quiet system because there is nobody triggers
syscall::open:entry and syscall::: probe while test execution.

Add a simple script to generate some noise, it sleeps for 1 second at begining
because current dtest script doesn't support execute a program after invoking
dtrace script.

Test Plan

cd /usr/tests/cddl/usr.sbin/dtrace/common/speculation && kyua debug t_dtrace_contrib:tst_NoSpecBuffer_d

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10649
Build 11053: arc lint + arc unit

Event Timeline

lwhsu created this revision.Jul 20 2017, 5:15 PM
Herald added 1 blocking reviewer(s): gnn. · View Herald TranscriptJul 20 2017, 5:15 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B10586: Diff 31011.Jul 20 2017, 5:15 PM
ngie edited edge metadata.Jul 20 2017, 5:19 PM

Why is a binary file being checked in?

lwhsu added a comment.Jul 20 2017, 5:30 PM
In D11671#241800, @ngie wrote:

Why is a binary file being checked in?

That's not a binary file, it's a script which needs to be run while test running, like other .exe files in test suite. arc(1) treats it as binary...

lwhsu updated this revision to Diff 31016.EditedJul 20 2017, 5:33 PM

svn ps svn:mime-type text/plain tst.NoSpecBuffer.exe

Harbormaster completed remote builds in B10589: Diff 31016.Jul 20 2017, 5:33 PM
markj added inline comments.Jul 23 2017, 7:56 PM
cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/speculation/tst.NoSpecBuffer.exe
28

This is susceptible to the same race I mentioned in the other review. IMO it is better to just loop forever and let the test harness kill the .exe process once the test has passed.

lwhsu updated this revision to Diff 31109.Jul 23 2017, 9:09 PM

Use infinite loop

lwhsu marked an inline comment as done.Jul 23 2017, 9:10 PM
Harbormaster completed remote builds in B10635: Diff 31109.Jul 23 2017, 9:10 PM
markj accepted this revision.Jul 24 2017, 1:01 AM
lwhsu updated this revision to Diff 31143.Jul 24 2017, 9:59 PM
lwhsu edited edge metadata.

Add a sleep(1) to avoid CPU busy loop.

Harbormaster completed remote builds in B10649: Diff 31143.Jul 24 2017, 9:59 PM
gnn accepted this revision.Jul 25 2017, 10:25 AM
This revision is now accepted and ready to land.Jul 25 2017, 10:25 AM
Closed by commit rS321465: Add a simple script which calls open(2) and others to generate events for (authored by lwhsu). · Explain WhyJul 25 2017, 12:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
cddl/
contrib/
opensolaris/
cmd/
dtrace/
test/
tst/
common/
speculation/
1 line
30 lines
usr.sbin/
dtrace/
tests/
common/
speculation/
1 line

Diff 31143

View Options

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/speculation/tst.NoSpecBuffer.d

Loading...
View Options

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/speculation/tst.NoSpecBuffer.exe

Loading...
View Options

cddl/usr.sbin/dtrace/tests/common/speculation/Makefile

Loading...