Page MenuHomeFreeBSD
Differential D11543

Update KomodoEdit from 6.x to 10.2.2
ClosedPublic
Actions

Authored by allanjude on Jul 9 2017, 9:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 11, 5:23 AM
Unknown Object (File)
Mon, Nov 10, 9:42 PM
Unknown Object (File)
Mon, Nov 10, 9:32 PM
Unknown Object (File)
Mon, Nov 10, 9:26 PM
Unknown Object (File)
Mon, Nov 10, 7:03 PM
Unknown Object (File)
Tue, Nov 4, 10:46 PM
Unknown Object (File)
Fri, Oct 24, 10:21 PM
Unknown Object (File)
Oct 13 2025, 1:51 AM
View All Files
Subscribers
mat

Details

Reviewers
brnrd
netchild
mmokhi
feld
mat
Commits
rP445754: editors/komodo-edit: Update port from 6.x to 10.2.2
Summary

Fix my text editor

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

allanjude created this revision.Jul 9 2017, 9:56 AM
Herald added a subscriber: mat. · View Herald TranscriptJul 9 2017, 9:56 AM
Harbormaster completed remote builds in B10406: Diff 30600.Jul 9 2017, 9:56 AM
netchild accepted this revision.Jul 9 2017, 11:02 AM

Looks OK for me (after wrapping my head around PLIST_FILES and PORTDATA and how the port installs the files).

This revision is now accepted and ready to land.Jul 9 2017, 11:02 AM
mmokhi accepted this revision.Jul 9 2017, 4:32 PM

Tested via poudriere and portlint.
it's fine.

mmokhi added reviewers: feld, mat.Jul 9 2017, 4:33 PM
mat requested changes to this revision.Jul 11 2017, 12:04 PM
mat added inline comments.
editors/komodo-edit/Makefile
36 ↗(On Diff #30600)

I can't believe this does not give a warning. Symlinks inside PREFIX must be relative.

So, you can either manually compute the relative path yourself, or do:

​ ${RLN} ${STAGEDIR}${DATADIR}/bin/komodo ${STAGEDIR}${PREFIX}/bin
This revision now requires changes to proceed.Jul 11 2017, 12:04 PM
mmokhi updated this revision to Diff 30646.Jul 11 2017, 1:51 PM
mmokhi edited edge metadata.

Use the ${RLN} instead of {LN} as @mat suggested.

Harbormaster completed remote builds in B10427: Diff 30646.Jul 11 2017, 1:51 PM
mat accepted this revision.Jul 11 2017, 9:55 PM
This revision is now accepted and ready to land.Jul 11 2017, 9:55 PM
Closed by commit rP445754: editors/komodo-edit: Update port from 6.x to 10.2.2 (authored by mmokhi). · Explain WhyJul 14 2017, 1:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
editors/
komodo-edit/
13 lines
5 lines

Diff 30782

View Options

head/editors/komodo-edit/Makefile

Loading...
View Options

head/editors/komodo-edit/distinfo

Loading...