Tags

None

Referenced Files

	F122495836: D11080.id29291.diff
	Sat, Jul 5, 6:58 PM

	Unknown Object (File)
	Tue, Jul 1, 10:18 AM

	Unknown Object (File)
	Tue, Jul 1, 3:20 AM

	Unknown Object (File)
	Mon, Jun 30, 5:30 AM

	Unknown Object (File)
	Sun, Jun 29, 3:19 PM

	Unknown Object (File)
	Fri, Jun 27, 6:21 AM

	Unknown Object (File)
	Mon, Jun 23, 8:15 AM

	Unknown Object (File)
	Sat, Jun 21, 4:32 AM

View All Files

Subscribers

andrew

jhibbits

Details

Reviewers

jhb
emaste
imp

Commits

rS319875: Add ptrace(PT_GET_SC_ARGS) command to return debuggee' current syscall

Summary

This allows to remove td_dbg_sc_code and td_dbg_sc_nargs.
Also, it allows to optionally print the syscall number in nosys().
Also, add PT_GET_SC_ARGS argument fetch operation for ptrace(2).

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Right now this is only compiled on i386/amd64. PT_GET_SC_ARGS is not tested and not documented.

Handle compat32: simply copy out low 32bits from each arg. This should be, in fact, a correct truncation.

Adapt !x86 arches.

Herald added subscribers: jhibbits, andrew. · View Herald TranscriptJun 10 2017, 10:07 PM

Document PT_GET_SC_ARGS.

Looks good to me. For full truss cleanup I'll also eventually want a PT_GET_SC_RVAL that returns td_retval[] and the translated error value from the system call (though I could also accept the "raw" error and do the translation in userland via the tables in libsysdecode). That one is easy enough I can add when adopting truss to use this.

This revision is now accepted and ready to land.Jun 12 2017, 5:29 PM

Update patch to the current state, including fixes to PT_GET_SC_ARGS (it passes tests) and to scescx.c test itself.

This revision now requires review to proceed.Jun 12 2017, 8:37 PM

Closed by commit rS319875: Add ptrace(PT_GET_SC_ARGS) command to return debuggee' current syscall (authored by kib). · Explain WhyJun 12 2017, 9:15 PM

This revision was automatically updated to reflect the committed changes.

Move syscall_args into struct thread.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29460

lib/libc/sys/ptrace.2

sys/amd64/amd64/trap.c

sys/amd64/cloudabi32/cloudabi32_sysvec.c

sys/amd64/cloudabi64/cloudabi64_sysvec.c

sys/amd64/ia32/ia32_syscall.c

sys/amd64/include/proc.h

sys/amd64/linux/linux_sysvec.c

sys/amd64/linux32/linux32_sysvec.c

sys/arm/arm/syscall.c

sys/arm/cloudabi32/cloudabi32_sysvec.c

sys/arm64/arm64/trap.c

sys/arm64/cloudabi64/cloudabi64_sysvec.c

sys/arm64/include/proc.h

sys/compat/ia32/ia32_util.h

sys/i386/cloudabi32/cloudabi32_sysvec.c

sys/i386/i386/trap.c

sys/i386/include/proc.h

sys/i386/linux/linux_sysvec.c

sys/kern/init_main.c

sys/kern/kern_fork.c

sys/kern/kern_sig.c

sys/kern/kern_thread.c

sys/kern/subr_syscall.c

sys/kern/sys_process.c

sys/mips/include/proc.h

sys/mips/mips/trap.c

sys/powerpc/include/proc.h

sys/powerpc/powerpc/trap.c

sys/riscv/include/proc.h

sys/riscv/riscv/trap.c

sys/sparc64/include/proc.h

sys/sparc64/sparc64/trap.c

sys/sys/proc.h

sys/sys/ptrace.h

sys/sys/sysent.h

Move syscall_args into struct thread.
ClosedPublic
Actions

Revision Contents
Changeset List