Page MenuHomeFreeBSD
Differential D10129

Add a fixup-lib-pkgconfig target to move files in lib/pkgconfig into libdata/pkgconfig.
ClosedPublic
Actions

Authored by mat on Mar 24 2017, 4:22 PM.
Tags
None
Referenced Files
F81623959: D10129.diff
Fri, Apr 19, 3:56 AM
Unknown Object (File)
Sun, Apr 14, 4:29 AM
Unknown Object (File)
Thu, Apr 11, 5:19 PM
Unknown Object (File)
Sat, Apr 6, 2:34 PM
Unknown Object (File)
Fri, Mar 22, 3:15 PM
Unknown Object (File)
Fri, Mar 22, 3:15 PM
Unknown Object (File)
Fri, Mar 22, 3:15 PM
Unknown Object (File)
Fri, Mar 22, 3:15 PM
View All 75 Files
Subscribers
antoine
rene

Details

Reviewers
None
Group Reviewers
portmgr
Commits
rP442784: Add a fixup-lib-pkgconfig target to move files in lib/pkgconfig into

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 9571
Build 10018: arc lint + arc unit

Event Timeline

mat created this revision.Mar 24 2017, 4:22 PM
rene added a subscriber: rene.Mar 24 2017, 4:50 PM
rene added inline comments.
audio/msbcg729/pkg-plist
4

Why make this a comment?

sysutils/fluent-bit/pkg-plist
692

Why make this a comment?

antoine added a subscriber: antoine.Mar 24 2017, 5:14 PM

Wouldn't this break hier for linux ports? (/compat/linux/libdata/pkgconfig instead of /compat/linux/lib/pkgconfig)

mat added a comment.Mar 24 2017, 6:57 PM
In D10129#209377, @antoine wrote:

Wouldn't this break hier for linux ports? (/compat/linux/libdata/pkgconfig instead of /compat/linux/lib/pkgconfig)

I had not thought about that, but, hey, this is why we have reviews :-)
It is easy to fix though.

audio/msbcg729/pkg-plist
4

Well, first, because it was commented out before, and second, the port installs libmsbcg729, and the .pc file is about libbcg729, third, audio/bcg729 already installs that .pc file.

sysutils/fluent-bit/pkg-plist
692

Because msgpack is a bundled lib, and it would conflict with devel/msgpack.

mat updated this revision to Diff 26635.Mar 24 2017, 7:01 PM
  • Don't fixup lib/pkgconfig for linux ports.
Harbormaster completed remote builds in B8278: Diff 26635.Mar 24 2017, 7:01 PM
mat updated this revision to Diff 26636.Mar 24 2017, 7:08 PM
  • Actually do what I mean.
Harbormaster completed remote builds in B8279: Diff 26636.Mar 24 2017, 7:08 PM
mat updated this revision to Diff 29002.May 30 2017, 9:37 AM

rebase.

Harbormaster completed remote builds in B9571: Diff 29002.May 30 2017, 9:37 AM
mat marked 4 inline comments as done.May 30 2017, 9:51 AM
Closed by commit rP442784: Add a fixup-lib-pkgconfig target to move files in lib/pkgconfig into (authored by mat). · Explain WhyJun 6 2017, 4:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
Mk/
15 lines
audio/
lilv/
3 lines
lv2/
4 lines
msbcg729/
2 lines
sratom/
1 line
1 line
suil/
1 line
1 line
databases/
monetdb/
1 line
deskutils/
cairo-dock-plugins/
3 lines
devel/
google-perftools/
2 lines
serd/
1 line
sord/
1 line
1 line
security/
gnomint/
3 lines
sysutils/
fluent-bit/
2 lines
x11-toolkits/
gtkada/
2 lines

Diff 29002

View Options

Mk/bsd.port.mk

Loading...
View Options

audio/lilv/Makefile

Loading...
View Options

audio/lv2/Makefile

Loading...
View Options

audio/msbcg729/pkg-plist

Loading...
View Options

audio/sratom/Makefile

Loading...
View Options

audio/sratom/pkg-plist

Loading...
View Options

audio/suil/Makefile

Loading...
View Options

audio/suil/pkg-plist

Loading...
View Options

databases/monetdb/Makefile

Loading...
View Options

deskutils/cairo-dock-plugins/Makefile

Loading...
View Options

devel/google-perftools/Makefile

Loading...
View Options

devel/serd/Makefile

Loading...
View Options

devel/sord/Makefile

Loading...
View Options

devel/sord/pkg-plist

Loading...
View Options

security/gnomint/Makefile

Loading...
View Options

sysutils/fluent-bit/pkg-plist

Loading...
View Options

x11-toolkits/gtkada/Makefile

Loading...