Page MenuHomeFreeBSD

Add a fixup-lib-pkgconfig target to move files in lib/pkgconfig into libdata/pkgconfig.
ClosedPublic

Authored by mat on Mar 24 2017, 4:22 PM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mat created this revision.Mar 24 2017, 4:22 PM
rene added a subscriber: rene.Mar 24 2017, 4:50 PM
rene added inline comments.
audio/msbcg729/pkg-plist
4 ↗(On Diff #26632)

Why make this a comment?

sysutils/fluent-bit/pkg-plist
690 ↗(On Diff #26632)

Why make this a comment?

Wouldn't this break hier for linux ports? (/compat/linux/libdata/pkgconfig instead of /compat/linux/lib/pkgconfig)

mat added a comment.Mar 24 2017, 6:57 PM

Wouldn't this break hier for linux ports? (/compat/linux/libdata/pkgconfig instead of /compat/linux/lib/pkgconfig)

I had not thought about that, but, hey, this is why we have reviews :-)
It is easy to fix though.

audio/msbcg729/pkg-plist
4 ↗(On Diff #26632)

Well, first, because it was commented out before, and second, the port installs libmsbcg729, and the .pc file is about libbcg729, third, audio/bcg729 already installs that .pc file.

sysutils/fluent-bit/pkg-plist
690 ↗(On Diff #26632)

Because msgpack is a bundled lib, and it would conflict with devel/msgpack.

mat updated this revision to Diff 26635.Mar 24 2017, 7:01 PM
  • Don't fixup lib/pkgconfig for linux ports.
mat updated this revision to Diff 26636.Mar 24 2017, 7:08 PM
  • Actually do what I mean.
mat updated this revision to Diff 29002.May 30 2017, 9:37 AM

rebase.

mat marked 4 inline comments as done.May 30 2017, 9:51 AM
This revision was automatically updated to reflect the committed changes.