Paths

Table of Contentst

Differential D10663

libstand: NULL pointer dereference in rarp
ClosedPublic
Actions

Authored by tsoome on May 10 2017, 3:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jun 1, 5:31 PM

	Unknown Object (File)
	Wed, May 22, 12:30 PM

	Unknown Object (File)
	Tue, May 21, 2:54 AM

	Unknown Object (File)
	Tue, May 21, 12:19 AM

	Unknown Object (File)
	Fri, May 17, 9:22 PM

	Unknown Object (File)
	May 7 2024, 11:54 AM

	Unknown Object (File)
	May 3 2024, 7:17 AM

	Unknown Object (File)
	May 2 2024, 4:03 PM

View All 32 Files

Subscribers

Details

Reviewers

Commits

rS318142: libstand: NULL pointer dereference in rarp

Summary

readether argument is missing & operator.
CID 1374944

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome created this revision.May 10 2017, 3:21 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 10 2017, 3:21 PM

cem accepted this revision.May 10 2017, 3:22 PM

This revision is now accepted and ready to land.May 10 2017, 3:22 PM

I'd suggest changing this interface from void ** to more typed pointers to catch this, although I'd expect GCC/Clang to catch passing a void * to void ** parameter. Maybe check WARNS level?

In D10663#221137, @cem wrote:

I'd suggest changing this interface from void ** to more typed pointers to catch this, although I'd expect GCC/Clang to catch passing a void * to void ** parameter. Maybe check WARNS level?

I think eventually we need there a bit more generic buffer structure to allow custom alignment, but that idea needs more time to settle.

tsoome edited the summary of this revision. (Show Details)May 10 2017, 3:33 PM

Closed by commit rS318142: libstand: NULL pointer dereference in rarp (authored by tsoome). · Explain WhyMay 10 2017, 3:36 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B9171: Diff 28200.May 10 2017, 4:40 PM

Revision Contents
Changeset List

Path

Size

head/

lib/

libstand/

2 lines

Diff 28201

head/lib/libstand/rarp.c

Loading...