Page MenuHomeFreeBSD
Differential D10663

libstand: NULL pointer dereference in rarp
ClosedPublic
Actions

Authored by tsoome on May 10 2017, 3:21 PM.
Tags
None
Referenced Files
F82794843: D10663.id28200.diff
Thu, May 2, 4:03 PM
F82794408: D10663.id.diff
Thu, May 2, 3:57 PM
F82794323: D10663.id28201.diff
Thu, May 2, 3:56 PM
F82778066: D10663.diff
Thu, May 2, 12:56 PM
Unknown Object (File)
Fri, Apr 26, 1:42 PM
Unknown Object (File)
Thu, Apr 25, 10:29 PM
Unknown Object (File)
Tue, Apr 23, 4:22 PM
Unknown Object (File)
Mar 18 2024, 8:48 PM
View All 25 Files
Subscribers
imp

Details

Reviewers
cem
Commits
rS318142: libstand: NULL pointer dereference in rarp
Summary

readether argument is missing & operator.
CID 1374944

Diff Detail

Event Timeline

tsoome created this revision.May 10 2017, 3:21 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 10 2017, 3:21 PM
cem accepted this revision.May 10 2017, 3:22 PM
This revision is now accepted and ready to land.May 10 2017, 3:22 PM
cem added a comment.May 10 2017, 3:22 PM

I'd suggest changing this interface from void ** to more typed pointers to catch this, although I'd expect GCC/Clang to catch passing a void * to void ** parameter. Maybe check WARNS level?

tsoome added a comment.May 10 2017, 3:33 PM
In D10663#221137, @cem wrote:

I'd suggest changing this interface from void ** to more typed pointers to catch this, although I'd expect GCC/Clang to catch passing a void * to void ** parameter. Maybe check WARNS level?

I think eventually we need there a bit more generic buffer structure to allow custom alignment, but that idea needs more time to settle.

tsoome edited the summary of this revision. (Show Details)May 10 2017, 3:33 PM
Closed by commit rS318142: libstand: NULL pointer dereference in rarp (authored by tsoome). · Explain WhyMay 10 2017, 3:36 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B9171: Diff 28200.May 10 2017, 4:40 PM

Revision Contents
Changeset List

PathSize
lib/
libstand/
2 lines

Diff 28200

View Options

lib/libstand/rarp.c

Loading...