Page MenuHomeFreeBSD

libstand: NULL pointer dereference in rarp
ClosedPublic

Authored by tsoome on May 10 2017, 3:21 PM.
Tags
None
Referenced Files
F82859574: D10663.diff
Fri, May 3, 7:17 AM
F82794843: D10663.id28200.diff
Thu, May 2, 4:03 PM
F82794408: D10663.id.diff
Thu, May 2, 3:57 PM
F82794323: D10663.id28201.diff
Thu, May 2, 3:56 PM
F82778066: D10663.diff
Thu, May 2, 12:56 PM
Unknown Object (File)
Fri, Apr 26, 1:42 PM
Unknown Object (File)
Thu, Apr 25, 10:29 PM
Unknown Object (File)
Tue, Apr 23, 4:22 PM
Subscribers

Details

Summary

readether argument is missing & operator.
CID 1374944

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 10 2017, 3:22 PM

I'd suggest changing this interface from void ** to more typed pointers to catch this, although I'd expect GCC/Clang to catch passing a void * to void ** parameter. Maybe check WARNS level?

In D10663#221137, @cem wrote:

I'd suggest changing this interface from void ** to more typed pointers to catch this, although I'd expect GCC/Clang to catch passing a void * to void ** parameter. Maybe check WARNS level?

I think eventually we need there a bit more generic buffer structure to allow custom alignment, but that idea needs more time to settle.

This revision was automatically updated to reflect the committed changes.