Page MenuHomeFreeBSD

libstand: NULL pointer dereference in rarp
ClosedPublic

Authored by tsoome on May 10 2017, 3:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 24, 12:47 PM
Unknown Object (File)
Fri, Sep 26, 5:05 PM
Unknown Object (File)
Sep 4 2025, 12:32 AM
Unknown Object (File)
Aug 1 2025, 11:27 AM
Unknown Object (File)
Jul 29 2025, 9:08 AM
Unknown Object (File)
Jul 28 2025, 2:12 PM
Unknown Object (File)
Jul 9 2025, 4:36 PM
Unknown Object (File)
Jun 21 2025, 3:55 PM
Subscribers

Details

Summary

readether argument is missing & operator.
CID 1374944

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 10 2017, 3:22 PM

I'd suggest changing this interface from void ** to more typed pointers to catch this, although I'd expect GCC/Clang to catch passing a void * to void ** parameter. Maybe check WARNS level?

In D10663#221137, @cem wrote:

I'd suggest changing this interface from void ** to more typed pointers to catch this, although I'd expect GCC/Clang to catch passing a void * to void ** parameter. Maybe check WARNS level?

I think eventually we need there a bit more generic buffer structure to allow custom alignment, but that idea needs more time to settle.

This revision was automatically updated to reflect the committed changes.