Page MenuHomeFreeBSD

libstand: NULL pointer dereference in rarp
ClosedPublic

Authored by tsoome on May 10 2017, 3:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 15, 2:44 PM
Unknown Object (File)
Mon, Apr 13, 3:15 AM
Unknown Object (File)
Sun, Apr 12, 7:25 PM
Unknown Object (File)
Sun, Apr 12, 7:14 AM
Unknown Object (File)
Sun, Apr 12, 4:29 AM
Unknown Object (File)
Sat, Apr 11, 11:10 PM
Unknown Object (File)
Thu, Apr 9, 2:47 AM
Unknown Object (File)
Wed, Apr 8, 5:52 PM
Subscribers

Details

Summary

readether argument is missing & operator.
CID 1374944

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 10 2017, 3:22 PM

I'd suggest changing this interface from void ** to more typed pointers to catch this, although I'd expect GCC/Clang to catch passing a void * to void ** parameter. Maybe check WARNS level?

In D10663#221137, @cem wrote:

I'd suggest changing this interface from void ** to more typed pointers to catch this, although I'd expect GCC/Clang to catch passing a void * to void ** parameter. Maybe check WARNS level?

I think eventually we need there a bit more generic buffer structure to allow custom alignment, but that idea needs more time to settle.

This revision was automatically updated to reflect the committed changes.