Paths

Table of Contentst

Differential D10663

libstand: NULL pointer dereference in rarp
ClosedPublic
Actions

Authored by tsoome on May 10 2017, 3:21 PM.

Tags

None

Referenced Files

	F170939366: D10663.id28201.diff
	Mon, Sep 7, 6:03 PM

	Unknown Object (File)
	Mon, Sep 7, 12:31 AM

	Unknown Object (File)
	Sun, Sep 6, 2:40 PM

	Unknown Object (File)
	Sun, Sep 6, 9:02 AM

	Unknown Object (File)
	Sun, Sep 6, 3:42 AM

	Unknown Object (File)
	Sun, Sep 6, 1:38 AM

	Unknown Object (File)
	Sat, Sep 5, 6:27 AM

	Unknown Object (File)
	Fri, Sep 4, 4:22 AM

Subscribers

Details

Reviewers

Commits

rS318142: libstand: NULL pointer dereference in rarp

Summary

readether argument is missing & operator.
CID 1374944

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9171
Build 9614: CI src build	Jenkins
Build 9613: arc lint + arc unit

Event Timeline

tsoome created this revision.May 10 2017, 3:21 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 10 2017, 3:21 PM

cem accepted this revision.May 10 2017, 3:22 PM

This revision is now accepted and ready to land.May 10 2017, 3:22 PM

I'd suggest changing this interface from void ** to more typed pointers to catch this, although I'd expect GCC/Clang to catch passing a void * to void ** parameter. Maybe check WARNS level?

In D10663#221137, @cem wrote:

I'd suggest changing this interface from void ** to more typed pointers to catch this, although I'd expect GCC/Clang to catch passing a void * to void ** parameter. Maybe check WARNS level?

I think eventually we need there a bit more generic buffer structure to allow custom alignment, but that idea needs more time to settle.

tsoome edited the summary of this revision. (Show Details)May 10 2017, 3:33 PM

Closed by commit rS318142: libstand: NULL pointer dereference in rarp (authored by tsoome). · Explain WhyMay 10 2017, 3:36 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B9171: Diff 28200.May 10 2017, 4:40 PM

Revision Contents
Changeset List

Path

Size

lib/

libstand/

2 lines

Diff 28200

lib/libstand/rarp.c

Loading...