Page MenuHomeFreeBSD

libstand: NULL pointer dereference in rarp
ClosedPublic

Authored by tsoome on May 10 2017, 3:21 PM.
Tags
None
Referenced Files
F86552854: D10663.id28200.diff
Sat, Jun 22, 2:06 AM
Unknown Object (File)
Sat, Jun 1, 5:31 PM
Unknown Object (File)
May 22 2024, 12:30 PM
Unknown Object (File)
May 21 2024, 2:54 AM
Unknown Object (File)
May 21 2024, 12:19 AM
Unknown Object (File)
May 17 2024, 9:22 PM
Unknown Object (File)
May 7 2024, 11:54 AM
Unknown Object (File)
May 3 2024, 7:17 AM
Subscribers

Details

Summary

readether argument is missing & operator.
CID 1374944

Diff Detail

Event Timeline

This revision is now accepted and ready to land.May 10 2017, 3:22 PM

I'd suggest changing this interface from void ** to more typed pointers to catch this, although I'd expect GCC/Clang to catch passing a void * to void ** parameter. Maybe check WARNS level?

In D10663#221137, @cem wrote:

I'd suggest changing this interface from void ** to more typed pointers to catch this, although I'd expect GCC/Clang to catch passing a void * to void ** parameter. Maybe check WARNS level?

I think eventually we need there a bit more generic buffer structure to allow custom alignment, but that idea needs more time to settle.

This revision was automatically updated to reflect the committed changes.