[privatelib] install libevent1 and sqlite3 headers to faciliate base tool development I'd like to use the in-system private libevent1 and sqlite3 headers to faciliate new base tools. Since libevent1 is pretty small compared to libevent2, I would...
ClosedPublic
Actions

Authored by adrian on Mar 23 2017, 7:13 PM.

Details

Reviewers

bapt
bdrewery

Commits

rS316063: [private] add libevent1 and sqlite3 include files for our private libraries.

Summary

...also like to eventually look at migrating the various versions of cooked-up
event IO loops, signal handling, etc into using our libvent1 library version.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Mar 23 2017, 7:13 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 23 2017, 7:13 PM

adrian added a reviewer: bapt.Mar 23 2017, 7:17 PM

I don't quite understand your reasoning. Are you wanting to use these for your own purposes or for actually developing something that is *in tree*? If it is in-tree, then I can explain a process to use that will make this not needed.

Well, I'd also like to cross build some stuff that's external (like tools/tools/ath/) too. This is done for ucl, which makes it easy to include that.

bdrewery requested changes to this revision.Mar 23 2017, 7:33 PM

bdrewery added inline comments.

lib/libevent/Makefile
13 ↗	(On Diff #26618)	This line serves no purpose, might as well remove it in lieu of adding INCS.

This revision now requires changes to proceed.Mar 23 2017, 7:33 PM

Harbormaster completed remote builds in B8267: Diff 26618.Mar 23 2017, 8:35 PM

Updating D10123: [privatelib] install libevent1 and sqlite3 headers to faciliate base tool development

I'd like to use the in-system private libevent1 and sqlite3 headers to faciliate
new base tools. Since libevent1 is pretty small compared to libevent2, I would...

adrian marked an inline comment as done.Mar 25 2017, 8:32 PM

Harbormaster completed remote builds in B8287: Diff 26654.Mar 25 2017, 9:08 PM

Seems ok to me at quick glance, I would anyway go to a provite libevent2 in second steps rather than libevent1, performance are way better in libevent2 and given we would keep it private we could decide to only build what we need if size matters.

hi!

libevent2 is .. very big compared to the footprint of libevent1, even the base. If someone wants to do it as a separate pass and show we can get the size down to libevent1 size, then great. :)

bdrewery accepted this revision.Mar 27 2017, 9:36 PM

This revision is now accepted and ready to land.Mar 27 2017, 9:36 PM

Closed by commit rS316063: [private] add libevent1 and sqlite3 include files for our private libraries. (authored by adrian). · Explain WhyMar 27 2017, 10:34 PM

This revision was automatically updated to reflect the committed changes.

In D10123#209648, @adrian wrote:

hi!

libevent2 is .. very big compared to the footprint of libevent1, even the base. If someone wants to do it as a separate pass and show we can get the size down to libevent1 size, then great. :)

we already have libevent2 in base - contrib/ntp/sntp/libevent

emaste mentioned this in D17275: rename in-tree libevent v1 from libevent to libevent1.Nov 8 2019, 3:11 PM