Page MenuHomeFreeBSD
Differential D9039

Add a section about LXQt components to porters handbook
ClosedPublic
Actions

Authored by sevan on Jan 4 2017, 5:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 11, 2:39 PM
Unknown Object (File)
Tue, Apr 8, 12:17 AM
Unknown Object (File)
Thu, Mar 27, 5:06 AM
Unknown Object (File)
Mar 3 2025, 1:46 AM
Unknown Object (File)
Feb 27 2025, 4:10 AM
Unknown Object (File)
Feb 24 2025, 8:09 PM
Unknown Object (File)
Feb 23 2025, 4:27 PM
Unknown Object (File)
Feb 22 2025, 2:02 PM
View All Files
Subscribers
bjk
swills
wblock

Details

Reviewers
bjk
wblock
bcr
mat
Commits
rD50032: PR: 215650
Summary

Bug 215650

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sevan updated this revision to Diff 23594.Jan 4 2017, 5:17 AM
sevan retitled this revision from to Add a section about LXQt components to porters handbook.
sevan updated this object.
sevan edited the test plan for this revision. (Show Details)
sevan added a reviewer: bcr.
sevan set the repository for this revision to rD FreeBSD doc repository - subversion.
Herald added a reviewer: mat. · View Herald TranscriptJan 4 2017, 5:17 AM
swills added a subscriber: swills.Jan 9 2017, 7:47 PM

The components list seems to match up with Mk/Uses/lxqt.mk and the content looks fine to me.

bcr edited edge metadata.Jan 10 2017, 4:03 PM

2 textual suggestions...

en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
2906

Maybe s/brings/adds a/ ?

2908

Maybe s/through/from the/ ?

bjk added a subscriber: bjk.Jan 15 2017, 3:20 AM
bjk added inline comments.
en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
2863

It's probably best to explicitly say "commonly used components" to be clear about what these values are.

2880

I don't understand what this entry is -- is it helpers *for* additional CMake modules, or additional CMake modules that are helpful, or ...?

sevan updated this revision to Diff 24036.Jan 15 2017, 6:04 PM
sevan edited edge metadata.
Herald edited edge metadata. · View Herald TranscriptJan 15 2017, 6:05 PM
sevan marked 4 inline comments as done.Jan 15 2017, 6:05 PM

updated diff addressing the items listed.

bjk accepted this revision.Jan 15 2017, 9:57 PM
bjk added a reviewer: bjk.
wblock added a subscriber: wblock.Jan 24 2017, 7:50 PM
wblock added inline comments.
en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
2861

Suspect this should be "...and set <varname>USE_LXQT</varname>"

2863

Avoid the aside: "...below and also documented..." (and remember to remove the closing paren) (yes that's an aside, and this one too)

sevan updated this revision to Diff 24399.Jan 24 2017, 8:04 PM
sevan edited edge metadata.
Herald edited edge metadata. · View Herald TranscriptJan 24 2017, 8:04 PM
sevan marked 2 inline comments as done.Jan 24 2017, 8:05 PM

updated diff with context posted.

wblock added inline comments.Jan 27 2017, 3:23 PM
en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
2860

Try to avoid if/then sentences. Occasional use is okay, but still, try to avoid. Often just rearranging them gets rid of the if/then and pause:

Applications depending on LXQt should set
2863

Below, it just says "Available LXQt Components". Isn't that all of them? If it is, this can just say "...a list of needed components from the table below."

sevan updated this revision to Diff 25944.Mar 3 2017, 6:54 PM
sevan removed a reviewer: mat.
Herald added a reviewer: mat. · View Herald TranscriptMar 3 2017, 6:54 PM
sevan marked 2 inline comments as done.Mar 3 2017, 6:56 PM

Addressed the remaining two points.

wblock accepted this revision.Mar 3 2017, 7:20 PM
wblock added a reviewer: wblock.

Approved for great justice!

Closed by commit rD50032: PR: 215650 (authored by sevan). · Explain WhyMar 3 2017, 7:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
en_US.ISO8859-1/
books/
porters-handbook/
special/
57 lines

Diff 25944

View Options

en_US.ISO8859-1/books/porters-handbook/special/chapter.xml

Show First 20 Lines • Show All 211 Lines • ▼ Show 20 Lines if ((frame->tf_scause == EXCP_FAULT_STORE) ||
ftype = VM_PROT_EXECUTE; ftype = VM_PROT_EXECUTE;
} else { } else {
ftype = VM_PROT_READ; ftype = VM_PROT_READ;
} }
if (pmap_fault_fixup(map->pmap, va, ftype)) if (pmap_fault_fixup(map->pmap, va, ftype))
goto done; goto done;
if (map != kernel_map) { error = vm_fault_trap(map, va, ftype, VM_FAULT_NORMAL, &sig, &ucode);
/*
* Keep swapout from messing with us during this
* critical time.
*/
PROC_LOCK(p);
++p->p_lock;
PROC_UNLOCK(p);
/* Fault in the user page: */
error = vm_fault(map, va, ftype, VM_FAULT_NORMAL);
PROC_LOCK(p);
--p->p_lock;
PROC_UNLOCK(p);
} else {
/*
* Don't have to worry about process locking or stacks in the
* kernel.
*/
error = vm_fault(map, va, ftype, VM_FAULT_NORMAL);
}
alcUnsubmitted
Done
Inline Actions

I'm surprised to see this snippet brought back to life in the riscv code. We removed it from elsewhere in the source tree almost exactly 4 years ago (r287625).

I would suggest committing the removal of this snippet now, and thus separately from the rest.

alc: I'm surprised to see this snippet brought back to life in the riscv code. We removed it from…
if (error != KERN_SUCCESS) { if (error != KERN_SUCCESS) {
if (usermode) { if (usermode) {
sig = SIGSEGV;
if (error == KERN_PROTECTION_FAILURE)
ucode = SEGV_ACCERR;
else
ucode = SEGV_MAPERR;
call_trapsignal(td, sig, ucode, (void *)stval); call_trapsignal(td, sig, ucode, (void *)stval);
} else { } else {
if (pcb->pcb_onfault != 0) { if (pcb->pcb_onfault != 0) {
frame->tf_a[0] = error; frame->tf_a[0] = error;
frame->tf_sepc = pcb->pcb_onfault; frame->tf_sepc = pcb->pcb_onfault;
return; return;
} }
goto fatal; goto fatal;
▲ Show 20 Lines • Show All 139 Lines • Show Last 20 Lines