Page MenuHomeFreeBSD

Add a section about LXQt components to porters handbook
ClosedPublic

Authored by sevan on Jan 4 2017, 5:17 AM.

Details

Summary

Bug 215650

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

sevan retitled this revision from to Add a section about LXQt components to porters handbook.
sevan updated this object.
sevan edited the test plan for this revision. (Show Details)
sevan added a reviewer: bcr.
sevan set the repository for this revision to rD FreeBSD doc repository - subversion.

The components list seems to match up with Mk/Uses/lxqt.mk and the content looks fine to me.

2 textual suggestions...

en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
2905

Maybe s/brings/adds a/ ?

2907

Maybe s/through/from the/ ?

bjk added inline comments.
en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
2862

It's probably best to explicitly say "commonly used components" to be clear about what these values are.

2879

I don't understand what this entry is -- is it helpers *for* additional CMake modules, or additional CMake modules that are helpful, or ...?

sevan edited edge metadata.

updated diff addressing the items listed.

bjk added a reviewer: bjk.
wblock added inline comments.
en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
2861

Suspect this should be "...and set <varname>USE_LXQT</varname>"

2863

Avoid the aside: "...below and also documented..." (and remember to remove the closing paren) (yes that's an aside, and this one too)

sevan edited edge metadata.

updated diff with context posted.

en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
2860

Try to avoid if/then sentences. Occasional use is okay, but still, try to avoid. Often just rearranging them gets rid of the if/then and pause:

Applications depending on LXQt should set
2863

Below, it just says "Available LXQt Components". Isn't that all of them? If it is, this can just say "...a list of needed components from the table below."

sevan removed a reviewer: mat.
sevan marked 2 inline comments as done.Mar 3 2017, 6:56 PM

Addressed the remaining two points.

wblock added a reviewer: wblock.

Approved for great justice!

This revision was automatically updated to reflect the committed changes.