Add vm_mmap2(), vm_mprotect(), vm_msync(), vm_munlock(), vm_munmap(), and vm_madvise().
ClosedPublic
Actions

Authored by trasz on Jan 30 2017, 11:38 AM.

Details

Reviewers

kib
alc
dchagin
ed

Commits

rS313352: Add kern_vm_mmap2(), kern_vm_mprotect(), kern_vm_msync(), kern_vm_munlock(),

Summary

Add vm_mmap2(), vm_mprotect(), vm_msync(), vm_munlock(), vm_munmap(),
and vm_madvise(), and use them in various compats instead of their
sys_*() counterparts.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7082
Build 7261: arc lint + arc unit

Event Timeline

trasz updated this revision to Diff 24552.Jan 30 2017, 11:38 AM

trasz retitled this revision from to Add vm_mmap2(), vm_mprotect(), vm_msync(), vm_munlock(), vm_munmap(), and vm_madvise()..

trasz updated this object.

trasz edited the test plan for this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptJan 30 2017, 11:38 AM

Ed, Dmitry, could you test it? Thanks!

kib added a reviewer: alc.Jan 30 2017, 11:56 AM

I think this is a right change to do. But I suggest to follow the naming conventions of all other syscall subroutines and utilize the kern_ prefix. In other words, for instance vm_munlock() should be named kern_vm_munlock(). I do not think that we ever pretend that our VM is still Mach VM.

Rename by adding the kern_ prefix.

ed added inline comments.Jan 30 2017, 7:33 PM

sys/vm/vm_extern.h
74	Wouldn't it make more sense to just call them `kern_mmap()`, etc. and place these prototypes in `sys/sysproto.h`?

trasz added inline comments.Jan 31 2017, 4:50 PM

sys/vm/vm_extern.h
74	This would require either contaminating sys/sysproto.h with all the vm_offset_t, vm_size_t etc, or changing the types which is error prone. So I think the current way is safer, and the "kern_vm_" provides a hint to the reader that those are declared somewhere else.