Page MenuHomeFreeBSD
Differential D9253

Fix py-pykde4 against newest clang
ClosedPublic
Actions

Authored by adridg on Jan 19 2017, 10:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 13, 10:51 PM
Unknown Object (File)
Sat, Apr 6, 2:10 PM
Unknown Object (File)
Wed, Apr 3, 8:19 AM
Unknown Object (File)
Mar 5 2024, 4:17 PM
Unknown Object (File)
Mar 5 2024, 4:17 PM
Unknown Object (File)
Jan 28 2024, 6:06 AM
Unknown Object (File)
Jan 16 2024, 1:54 PM
Unknown Object (File)
Dec 30 2023, 5:06 PM
View All 60 Files
Subscribers
mat
kde

Details

Reviewers
tcberner
rakuco
jbeich
Commits
rP431949: Fix py-pykde4 against newest clang
Summary

PyList_SET_ITEM() is supposed to be void, but as a macro it's an
expression and has a pointer value. Clang 4.0 trips on the bogus
pointer comparison; given the comparison, it should be PyList_SetItem()
which returns -1 on failure.

Test Plan

py-kde4 builds with these patches on -CURRENT with the clang4 branch.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 6891
Build 7082: arc lint + arc unit

Event Timeline

adridg updated this revision to Diff 24219.Jan 19 2017, 10:58 PM
adridg retitled this revision from to Fix py-pykde4 against newest clang.
adridg updated this object.
adridg edited the test plan for this revision. (Show Details)
adridg added reviewers: tcberner, jbeich, rakuco.
adridg added a subscriber: kde.
Herald added a subscriber: mat. · View Herald TranscriptJan 19 2017, 10:58 PM
adridg updated this revision to Diff 24220.Jan 19 2017, 10:59 PM

Before Tobias reminds me that there should be an explanation of
why the patches are necessary ..

tcberner accepted this revision.Jan 20 2017, 7:49 AM
tcberner edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Jan 20 2017, 7:49 AM
Closed by commit rP431949: Fix py-pykde4 against newest clang (authored by tcberner). · Explain WhyJan 20 2017, 12:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24219

View Options

devel/py-pykde4/files/patch-sip_phonon_abstractvideodataoutput.sip

Loading...
View Options

devel/py-pykde4/files/patch-sip_solid_powermanagement.sip

Loading...
View Options

devel/py-pykde4/files/patch-sip_solid_predicate.sip

Loading...