Implement ppoll() function.
Add kern_ppoll() version needed by an upcoming Linuxulator change.
Perhaps need to specify that it is non-standard function, i.e., Linux specific?
Details
Details
- Reviewers
kib trasz - Group Reviewers
manpages - Commits
- rS274462: Add the ppoll() system call.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/libc/include/namespace.h | ||
|---|---|---|
| 85 ↗ | (On Diff #2336) | I do not see why is this needed. There is no ppoll(2) callers in libc. |
| lib/libc/sys/ppoll.2 | ||
| 1 ↗ | (On Diff #2336) | IMO, it would be more useful to change the poll(2) man page. The changes would consist of adding the function prototype, a paragraph with description, and symlink. The existing separate man pages for select(2) and pselect(2) are due to the history of pselect. It was initially implemented as library function with bug, and later reimplemented in kernel. In fact, it makes sense to merge select(2) and pselect(2) as well. |
| sys/kern/sys_generic.c | ||
| 1435 | Would it reduce code size by merging kern_poll and kern_ppoll() ? Make kern_poll() take struct timespec * and sigset_t *. | |
| sys/sys/poll.h | ||
| 35 | This namespace pollution must be under #Ifdef __BSD_VISIBLE. | |
| 115 | And this one too (__BSD_VISIBLE). | |
Comment Actions
Fixed.
in passing sys_poll() converted to c99, if this change is not needed, i'll remove it
Comment Actions
Overall, this looks good.
| lib/libc/sys/poll.2 | ||
|---|---|---|
| 154 | Line too long, wrap it. | |
| 156 | .Fa fds | |
| 164 | split the line, 'which is defined' is intrpreted as .Vt | |
| 232 | New sentence -> new line. | |
| sys/sys/poll.h | ||
| 107 | How does glibc handle this ? My gut feeling is that including sys/sigset.h and sys/timespec.h is the duty of the user code. Then, poll.h only needs to forward-declare struct timespec and struct __sigset. But we arguably should keep this compatible with Linux. | |
| lib/libc/sys/poll.2 | ||
|---|---|---|
| 152 | "unlike" is an aside, said with pauses: system call, unlike | |
| 154 | "allows" implies that it is optional. "is used to safely wait until..." | |
| 164 | Right: .Vt "const struct timespec" | |
| 169 | Rather than a semicolon, just break the sentence there: .Fn poll . | |
| sys/sys/poll.h | ||
|---|---|---|
| 107 | glibc does it for the user, it can be seen in io/sys/poll.h glibc header. | |
Comment Actions
The web interface shows some garbage for me.
When I download the raw diff, poll.2 chunks are duplicated. I have no idea is this yet another bug of the web review thing, or there is some problem with the patch.
Anyway, I do not have more comments.