Fix a regression in r310638.
ClosedPublic
Actions

Authored by kib on Jan 4 2017, 10:39 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 11, 10:23 AM

	Unknown Object (File)
	Sat, Apr 11, 10:04 AM

	Unknown Object (File)
	Fri, Apr 10, 12:36 AM

	Unknown Object (File)
	Thu, Mar 26, 7:52 AM

	Unknown Object (File)
	Thu, Mar 26, 7:52 AM

	Unknown Object (File)
	Tue, Mar 24, 1:38 AM

	Unknown Object (File)
	Mar 22 2026, 6:17 AM

	Unknown Object (File)
	Mar 17 2026, 5:32 AM

View All 97 Files

Subscribers

imp

pho

Details

Reviewers

jhb
trasz

Commits

rS311286: The callers of kern_getfsstat(UIO_SYSSPACE) expect that *buf always

Summary

The callers of kern_getfsstat(UIO_SYSSPACE) expect that *buf always return memory which must be freed, regardless of the error. Assign NULL to *buf in case we are not going to allocate any memory due to invalid mode.

Test Plan

Reported and tested by: pho

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 6558

Event Timeline

kib updated this revision to Diff 23597.Jan 4 2017, 10:39 AM

kib retitled this revision from to Fix a regression in r310638..

kib updated this object.

kib edited the test plan for this revision. (Show Details)

kib added reviewers: jhb, trasz.

kib set the repository for this revision to rS FreeBSD src repository - subversion.

kib added a subscriber: pho.

Herald added a subscriber: imp. · View Herald TranscriptJan 4 2017, 10:39 AM

jhb accepted this revision.Jan 4 2017, 3:46 PM

jhb edited edge metadata.

This revision is now accepted and ready to land.Jan 4 2017, 3:46 PM

Closed by commit rS311286: The callers of kern_getfsstat(UIO_SYSSPACE) expect that *buf always (authored by kib). · Explain WhyJan 4 2017, 4:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_syscalls.c

2 lines

Diff 23597

View Options

Fix a regression in r310638.ClosedPublicActions