Differential D9035

Protect calls to mtod() from accessing NULL mbufs
ClosedPublic
Actions

Authored by gnn on Jan 3 2017, 8:36 PM.

Tags

None

Referenced Files

	F109246410: D9035.diff
	Sun, Feb 2, 1:53 PM

	Unknown Object (File)
	Thu, Jan 30, 4:00 AM

	Unknown Object (File)
	Sun, Jan 26, 5:29 AM

	Unknown Object (File)
	Fri, Jan 24, 6:37 AM

	Unknown Object (File)
	Fri, Jan 10, 6:12 AM

	Unknown Object (File)
	Dec 7 2024, 10:25 PM

	Unknown Object (File)
	Nov 13 2024, 10:04 AM

	Unknown Object (File)
	Oct 28 2024, 7:09 AM

View All 60 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS311225: Fix DTrace TCP tracepoints to not use mtod() as it is both unnecessary and

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203409

Test Plan

Trace all debug output using a modified tcpdebug script that looks at all sockets

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6556
Build 6778: arc lint + arc unit

Event Timeline

gnn updated this revision to Diff 23585.Jan 3 2017, 8:36 PM

gnn retitled this revision from to Protect calls to mtod() from accessing NULL mbufs.

gnn updated this object.

gnn edited the test plan for this revision. (Show Details)

gnn added a reviewer: hiren.

Herald added a reviewer: transport. · View Herald TranscriptJan 3 2017, 8:36 PM

Herald added a subscriber: imp. · View Herald Transcript

Is it possible to handle 'm' being null in TCP_PROBE3() instead of these if/else checks everywhere?

hiren updated this object.Jan 3 2017, 8:58 PM

hiren edited edge metadata.

hiren added a subscriber: avg.

I could make an uglier macro. If that would please the audience.

In D9035#186666, @gnn wrote:

I could make an uglier macro. If that would please the audience.

Hah. Uglier macro in one place might probably be better?

I'll see what others have to say. :-)

Have you checked generated assembly? This likely executes a branch regardless of whether SDT is enabled. On the other putting the check in the macro should get around that.

We actually don't need mtod() at all. If you want the mbuf, use the mbuf provider.

Herald edited edge metadata. · View Herald TranscriptJan 4 2017, 1:44 AM

hiren accepted this revision.Jan 4 2017, 2:11 AM

hiren edited edge metadata.

This revision is now accepted and ready to land.Jan 4 2017, 2:11 AM

Closed by commit rS311225: Fix DTrace TCP tracepoints to not use mtod() as it is both unnecessary and (authored by gnn). · Explain WhyJan 4 2017, 2:19 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

25 lines

2 lines

7 lines

Diff 23589

sys/netinet/tcp_input.c

Loading...

sys/netinet/tcp_output.c

Loading...

sys/netinet/tcp_subr.c

Loading...