Page MenuHomeFreeBSD
Differential D8954

sfxge(4): do not use enum type when values are bitmask
ClosedPublic
Actions

Authored by arybchik on Dec 28 2016, 4:31 PM.
Tags
None
Referenced Files
F145100621: D8954.diff
Sun, Feb 15, 11:38 PM
F145091923: D8954.id23378.diff
Sun, Feb 15, 9:31 PM
Unknown Object (File)
Thu, Jan 29, 7:05 PM
Unknown Object (File)
Wed, Jan 28, 4:35 PM
Unknown Object (File)
Dec 29 2025, 1:10 AM
Unknown Object (File)
Nov 27 2025, 3:26 AM
Unknown Object (File)
Nov 26 2025, 1:03 AM
Unknown Object (File)
Nov 11 2025, 2:33 AM
View All Files
Subscribers
imp

Details

Reviewers
philip
np
gnn
bz
Commits
rS310756: sfxge(4): do not use enum type when values are bitmask
Summary

ICC complains that enumerated type mixed with another type.

Found by DPDK upstream build sanity check.

Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days

Test Plan

amd64 kernels tinderbox build tested
module load, interface up, RSS works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 6433
Build 6665: arc lint + arc unit

Event Timeline

arybchik updated this revision to Diff 23342.Dec 28 2016, 4:31 PM
arybchik retitled this revision from to sfxge(4): do not use enum type when values are bitmask.
arybchik updated this object.
arybchik edited the test plan for this revision. (Show Details)
arybchik added reviewers: gnn, philip, np, bz.
Herald added a subscriber: imp. · View Herald TranscriptDec 28 2016, 4:31 PM
gnn accepted this revision.Dec 28 2016, 4:46 PM
gnn edited edge metadata.
This revision is now accepted and ready to land.Dec 28 2016, 4:46 PM
Closed by commit rS310756: sfxge(4): do not use enum type when values are bitmask (authored by arybchik). · Explain WhyDec 29 2016, 7:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
sfxge/
common/
8 lines
12 lines
8 lines
4 lines

Diff 23342

View Options

head/sys/dev/sfxge/common/ef10_rx.c

Loading...
View Options

head/sys/dev/sfxge/common/efx.h

Loading...
View Options

head/sys/dev/sfxge/common/efx_rx.c

Loading...
View Options

head/sys/dev/sfxge/sfxge_rx.c

Loading...