sfxge(4): use correct port number in sensor decoding
ClosedPublic
Actions

Authored by arybchik on Dec 28 2016, 3:43 PM.

Details

Reviewers

philip
np
gnn
bz

Commits

rS310749: sfxge(4): use correct port number in sensor decoding

Summary

The port mask used for per-port sensors in mcdi_sensor_map
assumes zero-based port numbering. The port mask used in
the code is based on the one-based MCDI port number.

Fix this to lookup the correct per-port sensors, and to
allow reporting of sensor events from higher port numbers.

Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days

Test Plan

amd64 kernels tinderbox build tested

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 6426
Build 6658: arc lint + arc unit

Event Timeline

arybchik updated this revision to Diff 23335.Dec 28 2016, 3:43 PM

arybchik retitled this revision from to sfxge(4): use correct port number in sensor decoding.

arybchik updated this object.

arybchik edited the test plan for this revision. (Show Details)

arybchik added reviewers: gnn, philip, np, bz.

Herald added a subscriber: imp. · View Herald TranscriptDec 28 2016, 3:43 PM

gnn accepted this revision.Dec 28 2016, 4:44 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.Dec 28 2016, 4:44 PM

Closed by commit rS310749: sfxge(4): use correct port number in sensor decoding (authored by arybchik). · Explain WhyDec 29 2016, 6:57 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

common/

mcdi_mon.c

15 lines

Diff 23335

View Options

head/sys/dev/sfxge/common/mcdi_mon.c

sfxge(4): use correct port number in sensor decodingClosedPublicActions