sfxge(4): fix efx_ev_qpoll for non-Siena builds
ClosedPublic
Actions

Authored by arybchik on Dec 28 2016, 3:10 PM.

Details

Reviewers

philip
np
gnn
bz

Commits

rS310744: sfxge(4): fix efx_ev_qpoll for non-Siena builds

Summary

Both Siena and EF10 use the siena_ev_qpoll() implementation, but this
function is not defined in builds without EFSYS_OPT_SIENA.

Remove siena_ev_qpoll and inline it into efx_ev_qpoll to allow it
to be used in non-Siena builds.

Also remove outdated FIXME comment, as EF10 event batching/merging has
been implemented long ago without needing to modify this code.

Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 kernels tinderbox build tested.
Driver loaded/unloaded on Siena and EF10.
Traffic works fine.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 6418
Build 6651: arc lint + arc unit

Event Timeline

arybchik updated this revision to Diff 23327.Dec 28 2016, 3:10 PM

arybchik retitled this revision from to sfxge(4): fix efx_ev_qpoll for non-Siena builds.

arybchik updated this object.

arybchik edited the test plan for this revision. (Show Details)

arybchik added reviewers: gnn, philip, np, bz.

Herald added a subscriber: imp. · View Herald TranscriptDec 28 2016, 3:10 PM

gnn accepted this revision.Dec 28 2016, 4:40 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.Dec 28 2016, 4:40 PM

Closed by commit rS310744: sfxge(4): fix efx_ev_qpoll for non-Siena builds (authored by arybchik). · Explain WhyDec 29 2016, 6:49 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

common/

efx_ev.c

278 lines

Diff 23327

View Options

head/sys/dev/sfxge/common/efx_ev.c

sfxge(4): fix efx_ev_qpoll for non-Siena buildsClosedPublicActions