bhnd(4): Use a stable sort key to produce deterministic output
ClosedPublic
Actions

Authored by landonf on Dec 19 2016, 11:13 PM.

Details

Reviewers

emaste
adrian

Commits

rS310342: bhnd(4): Use a stable sort key to produce deterministic nvram_map_gen.awk

Summary

Use a guaranteed unique sort key (var_id, rev_start, rev_end) when
ordering SROM layout entries; otherwise, we see non-deterministic output
for entries with overlapping var_ids.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6322
Build 6561: arc lint + arc unit

Event Timeline

landonf updated this revision to Diff 23117.Dec 19 2016, 11:13 PM

landonf retitled this revision from to bhnd(4): Use a stable sort key to produce deterministic output.

landonf updated this object.

landonf edited the test plan for this revision. (Show Details)

landonf added reviewers: emaste, adrian.

landonf added subscribers: • lidl, gjb.

adrian accepted this revision.Dec 19 2016, 11:14 PM

adrian edited edge metadata.

This revision is now accepted and ready to land.Dec 19 2016, 11:14 PM

emaste accepted this revision.Dec 20 2016, 1:09 AM

emaste edited edge metadata.

emaste mentioned this in D8857: bhnd: remove srand() to produce deterministic output.

I tested this in my local WIP tree and confirm that I get the same output after each invocation.

Also,
PR: 215422

Closed by commit rS310342: bhnd(4): Use a stable sort key to produce deterministic nvram_map_gen.awk (authored by landonf). · Explain WhyDec 21 2016, 12:50 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

bhnd/

tools/

nvram_map_gen.awk

66 lines

Diff 23117

View Options

sys/dev/bhnd/tools/nvram_map_gen.awk

bhnd(4): Use a stable sort key to produce deterministic outputClosedPublicActions