bhnd: remove srand() to produce deterministic output
ClosedPublic
Actions

Authored by emaste on Dec 19 2016, 7:29 PM.

Details

Reviewers

landonf

Commits

rS310371: bhnd: remove srand() to ensure deterministic output

Summary

nvram_map_gen.awk uses rand() in its qsort implementation, to select the pivot. This results in non-deterministic output, presumably because one of the arrays has elements that compare identical but are in fact not.

A better fix may be to improve the comparison, so that no elements compare identical.

PR: 215422

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 23102.Dec 19 2016, 7:29 PM

emaste retitled this revision from to bhnd: remove srand() to produce deterministic output.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a reviewer: landonf.

emaste added subscribers: • lidl, gjb, adrian.

Need for this change obviated by D8859, although it's probably still sensible to make this change and have completely deterministic operation.

landonf accepted this revision.Dec 20 2016, 1:27 AM

landonf edited edge metadata.

This revision is now accepted and ready to land.Dec 20 2016, 1:27 AM

Closed by commit rS310371: bhnd: remove srand() to ensure deterministic output (authored by emaste). · Explain WhyDec 21 2016, 3:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

bhnd/

tools/

nvram_map_gen.awk

3 lines

Diff 23179

View Options

head/sys/dev/bhnd/tools/nvram_map_gen.awk

bhnd: remove srand() to produce deterministic outputClosedPublicActions