Paths

Table of Contentst

iasl: Remove date and time from -vd option, for reproducible build
AbandonedPublic
Actions

Authored by emaste on Dec 19 2016, 5:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 9, 7:32 PM

	Unknown Object (File)
	Tue, Sep 8, 3:00 PM

	Unknown Object (File)
	Sat, Sep 5, 11:43 PM

	Unknown Object (File)
	Thu, Sep 3, 7:22 AM

	Unknown Object (File)
	Thu, Aug 27, 5:07 PM

	Unknown Object (File)
	Sat, Aug 15, 7:49 PM

	Unknown Object (File)
	Wed, Aug 12, 2:19 PM

	Unknown Object (File)
	Wed, Aug 12, 2:18 PM

Subscribers

Details

Reviewers

jkim

Summary

iasl's use of __DATE__ and __TIME__ is one of two issues remaining preventing a reproducible build of FreeBSD world + kernel.

The build date and time is not particularly relevant, so just remove it (instead of pinning it to an arbitrary value, via e.g. SOURCE_DATE_EPOCH).

PR: 215421

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 23098.Dec 19 2016, 5:50 PM

emaste retitled this revision from to iasl: Remove nonreproducible -vd (build date & time) option.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a reviewer: jkim.

emaste added subscribers: bapt, jhb, gjb.

emaste added inline comments.Dec 20 2016, 8:15 PM

sys/contrib/dev/acpica/compiler/asloptions.c
735–736	I argue that this is not useful information and we're better off just omitting the option, but if prefered we could either change it to `"%s Build date/time: unknown\n", ASL_COMPILER_NAME`, or hard-code an arbitrary date/time.

Leave -vd in place, just remove the nonreproducible date and time

@jkim committed rS311529

Revision Contents
Changeset List

Path

Size

sys/

contrib/

dev/

acpica/

compiler/

asloptions.c

4 lines

Diff 23098

View Options

sys/contrib/dev/acpica/compiler/asloptions.c

iasl: Remove date and time from -vd option, for reproducible buildAbandonedPublicActions