Page MenuHomeFreeBSD
Differential D8748

Add basic ATF tests for Capability mode .. lookups
ClosedPublic
Actions

Authored by cem on Dec 11 2016, 4:07 AM.
Tags
None
Referenced Files
F106101189: D8748.diff
Wed, Dec 25, 10:18 AM
Unknown Object (File)
Wed, Dec 18, 7:47 PM
Unknown Object (File)
Mon, Dec 16, 4:57 AM
Unknown Object (File)
Tue, Dec 10, 10:50 AM
Unknown Object (File)
Oct 27 2024, 9:32 PM
Unknown Object (File)
Oct 24 2024, 9:49 PM
Unknown Object (File)
Sep 24 2024, 6:53 PM
Unknown Object (File)
Sep 17 2024, 3:20 PM
View All 92 Files
Subscribers
None

Details

Reviewers
kib
emaste
allanjude
ngie
oshogbo
Commits
rS309897: Add basic ATF tests for Capability mode .. lookups
Summary

To accompany https://reviews.freebsd.org/D8746 .

Test Plan

Could also use symlink tests. Anything else?

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6188
Build 6438: arc lint + arc unit

Event Timeline

cem updated this revision to Diff 22808.Dec 11 2016, 4:07 AM
cem retitled this revision from to Add basic ATF tests for Capability mode .. lookups.
cem updated this object.
cem edited the test plan for this revision. (Show Details)
cem added reviewers: emaste, allanjude, oshogbo, kib, ngie.
ngie added inline comments.Dec 11 2016, 4:33 AM
tests/sys/vfs/lookup_cap_dotdot.c
42

Why is this hardcoded to /tmp ? This violates the kyua test sandbox and makes this test impossible to cleanup after if it's interrupted or killed mid-test :(.

Honestly, it seems like you should be able to create a directory under the sandbox, 2 elements deep, which would fulfill your requirements.

57–61
ATF_CHECK(mkdirat(testdir_fd, "b", 0700) == 0);

is simpler.

85–98

This should be replaced with this simpler logic (which uses the feature_present(3) API):

#include "freebsd_test_suite/macros.h"

/* ... */

ATF_REQUIRE_FEATURE("security_capabilities");
ATF_REQUIRE_FEATURE("security_capability_mode");

Be sure to add:

CFLAGS+= ${SRCTOP}/tests

to the Makefile.

ngie edited edge metadata.Dec 11 2016, 4:34 AM

Could also use symlink tests. Anything else?

Tests that cross mount points, perhaps?

kib edited edge metadata.Dec 11 2016, 6:25 PM

I think it would be useful to include all tests from the original ed program, including non-capsicum kinds.
https://github.com/emaste/snippets/blob/master/test_openat.c

cem added a comment.Dec 11 2016, 6:43 PM
In D8748#181282, @kib wrote:

I think it would be useful to include all tests from the original ed program, including non-capsicum kinds.
https://github.com/emaste/snippets/blob/master/test_openat.c

Will do, thanks.

tests/sys/vfs/lookup_cap_dotdot.c
42

I'm unfamiliar with kyua sandboxing. How do I use it? Is it just the current directory during test body?

I'm not attached to /tmp, just not aware of anything better.

57–61

Ok.

85–98

Thanks. That's in HEAD or BODY?

cem updated this revision to Diff 22815.Dec 11 2016, 8:02 PM
cem marked 6 inline comments as done.
cem edited edge metadata.

Address ngie@ review feedback.

  • Use cwd (assuming that's the sandbox) instead of tmp, drop cleanup code
  • Use ATF_CHECK/ATF_REQUIRE for simplicity
  • Use ATF_REQUIRE_FEATURE macro instead of raw sysctls
cem updated this revision to Diff 22816.Dec 11 2016, 8:03 PM

Actually fix commit and push changes.

cem updated this revision to Diff 22818.Dec 11 2016, 9:37 PM

Bring in Ed's openat tests, adapted to ATF. Includes symlink tests.

oshogbo edited edge metadata.Dec 11 2016, 11:47 PM

We don't want to put it under tools/regression/capsicum ?

cem added a comment.Dec 12 2016, 12:03 AM
In D8748#181353, @oshogbo wrote:

We don't want to put it under tools/regression/capsicum ?

As an ATF test the logical place is under tests/. I don't know any good reason to prefer tools/regression over tests or vice versa, so as this is already implemented, I'm inclined to keep it as-is (if it isn't broken, don't fix it).

kib accepted this revision.Dec 12 2016, 10:47 AM
kib edited edge metadata.
kib added inline comments.
tests/sys/vfs/lookup_cap_dotdot.c
194

We use c89-style /* */ comments in FreeBSD source code.

This revision is now accepted and ready to land.Dec 12 2016, 10:47 AM
Closed by commit rS309897: Add basic ATF tests for Capability mode .. lookups (authored by cem). · Explain WhyDec 12 2016, 5:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
tests/
sys/
vfs/
2 lines
182 lines

Diff 22815

View Options

tests/sys/vfs/Makefile

Loading...
View Options

tests/sys/vfs/lookup_cap_dotdot.c

Loading...