hexdump(1): First cut capsicumification
ClosedPublic
Actions

Authored by cem on Sep 18 2016, 3:11 AM.

Details

Reviewers

Commits

rS310143: hexdump(1): First cut capsicumification

Summary

For now, only enter the sandbox for the last file processed (including
stdin for zero-argument mode).

Sandboxing all inputs will require a little restructuring of the
program.

Test Plan

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6175
Build 6429: arc lint + arc unit

cem retitled this revision from to hexdump(1): First cut capsicumification.

cem updated this object.

cem edited the test plan for this revision. (Show Details)

usr.bin/hexdump/display.c
340	extra blank line? also cap_rights_t should probably sort first
usr.bin/hexdump/hexdump.c
44–45	style(9) as previously noted
95	up to you but I think we can combine all of the cap_*_limit into one if statement and one error

usr.bin/hexdump/display.c
340	I think a blank line separating `static` variables from the rest makes it more clear that they aren't ordinary stack variables. Same reason to not have `rights` first.
usr.bin/hexdump/hexdump.c
44–45	Someone should actually add it to style(9) if we're going to keep claiming it's in there.
95	Sure.

usr.bin/hexdump/display.c
340	Ah I guess that makes sense.
usr.bin/hexdump/hexdump.c
44–45	Ok, just "style as previously noted" then :-) Yes, we need to make this explicit in the man page.