Page MenuHomeFreeBSD
Differential D8677

Rename PKG_CMD to PKG_REGISTER
ClosedPublic
Actions

Authored by bapt on Nov 30 2016, 10:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 25, 12:27 PM
Unknown Object (File)
Mon, Jun 24, 12:11 PM
Unknown Object (File)
Sun, Jun 23, 8:28 AM
Unknown Object (File)
Tue, Jun 18, 9:41 PM
Unknown Object (File)
Mon, Jun 17, 2:50 PM
Unknown Object (File)
Mon, Jun 17, 2:50 PM
Unknown Object (File)
Mon, Jun 17, 2:50 PM
Unknown Object (File)
Mon, Jun 17, 2:22 PM
View All 67 Files
Subscribers
mat
matthew
swills

Details

Reviewers
swills
bdrewery
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Commits
rP427523: Rename PKG_CMD to PKG_REGISTER
Summary

PKG_CMD is a legacy from the pkg_tools time, it is now defined in bsd.own.mk in
an incompatible way. Rename it PKG_REGISTER to avoid collision and have a
variable name more accurate

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 6096
Build 6357: arc lint + arc unit

Event Timeline

bapt updated this revision to Diff 22615.Nov 30 2016, 10:18 AM
bapt retitled this revision from to Rename PKG_CMD to PKG_REGISTER.
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added a reviewer: portmgr.
Owners added a reviewer: O5: Ports Framework.Nov 30 2016, 10:18 AM
Herald added a reviewer: bdrewery. · View Herald TranscriptNov 30 2016, 10:18 AM
Herald added a subscriber: mat. · View Herald Transcript
matthew added a subscriber: matthew.Nov 30 2016, 12:25 PM
mat added inline comments.Nov 30 2016, 4:29 PM
Mk/bsd.port.mk
1807–1809

What this intended ?

matthew mentioned this in D8120: Allow override of the pkg command used for 'make packages'.Nov 30 2016, 10:20 PM
bapt added inline comments.Dec 1 2016, 6:10 PM
Mk/bsd.port.mk
1807–1809

no I will make sure not to commit that :=)

swills accepted this revision.Dec 1 2016, 6:13 PM
swills added a reviewer: swills.
swills added a subscriber: swills.

Looks fine as long as you skip the part @mat pointed out.

This revision is now accepted and ready to land.Dec 1 2016, 6:13 PM
bdrewery accepted this revision.Dec 1 2016, 6:36 PM
bdrewery edited edge metadata.
Closed by commit rP427523: Rename PKG_CMD to PKG_REGISTER (authored by swills). · Explain WhyDec 1 2016, 9:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
Mk/
2 lines
7 lines
ports-mgmt/
pkg-devel/
2 lines

Diff 22615

View Options

Mk/bsd.commands.mk

Loading...
View Options

Mk/bsd.port.mk

Loading...
View Options

ports-mgmt/pkg-devel/Makefile

Loading...