Page MenuHomeFreeBSD
Differential D8677

Rename PKG_CMD to PKG_REGISTER
ClosedPublic
Actions

Authored by bapt on Nov 30 2016, 10:18 AM.
Tags
None
Referenced Files
F105902670: D8677.diff
Sun, Dec 22, 8:36 AM
Unknown Object (File)
Wed, Dec 11, 4:05 AM
Unknown Object (File)
Sun, Dec 8, 3:37 PM
Unknown Object (File)
Tue, Dec 3, 4:02 PM
Unknown Object (File)
Tue, Dec 3, 4:02 PM
Unknown Object (File)
Tue, Dec 3, 4:02 PM
Unknown Object (File)
Sat, Nov 30, 12:54 AM
Unknown Object (File)
Fri, Nov 22, 8:44 AM
View All Files
Subscribers
mat
matthew
swills

Details

Reviewers
swills
bdrewery
Group Reviewers
O5: Ports Framework
portmgr
Commits
rP427523: Rename PKG_CMD to PKG_REGISTER
Summary

PKG_CMD is a legacy from the pkg_tools time, it is now defined in bsd.own.mk in
an incompatible way. Rename it PKG_REGISTER to avoid collision and have a
variable name more accurate

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bapt updated this revision to Diff 22615.Nov 30 2016, 10:18 AM
bapt retitled this revision from to Rename PKG_CMD to PKG_REGISTER.
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added a reviewer: portmgr.
Owners added a reviewer: O5: Ports Framework.Nov 30 2016, 10:18 AM
Herald added a reviewer: bdrewery. · View Herald TranscriptNov 30 2016, 10:18 AM
Herald added a subscriber: mat. · View Herald Transcript
matthew added a subscriber: matthew.Nov 30 2016, 12:25 PM
mat added inline comments.Nov 30 2016, 4:29 PM
Mk/bsd.port.mk
1807–1809 ↗(On Diff #22615)

What this intended ?

matthew mentioned this in D8120: Allow override of the pkg command used for 'make packages'.Nov 30 2016, 10:20 PM
bapt added inline comments.Dec 1 2016, 6:10 PM
Mk/bsd.port.mk
1807–1809 ↗(On Diff #22615)

no I will make sure not to commit that :=)

swills accepted this revision.Dec 1 2016, 6:13 PM
swills added a reviewer: swills.
swills added a subscriber: swills.

Looks fine as long as you skip the part @mat pointed out.

This revision is now accepted and ready to land.Dec 1 2016, 6:13 PM
bdrewery accepted this revision.Dec 1 2016, 6:36 PM
bdrewery edited edge metadata.
Closed by commit rP427523: Rename PKG_CMD to PKG_REGISTER (authored by swills). · Explain WhyDec 1 2016, 9:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizePackages
head/
Mk/
2 linesO5: Ports Framework
4 linesO5: Ports Framework
ports-mgmt/
pkg-devel/
2 lines

Diff 22652

View Options

head/Mk/bsd.commands.mk

Loading...
View Options

head/Mk/bsd.port.mk

Loading...
View Options

head/ports-mgmt/pkg-devel/Makefile

Loading...