Page MenuHomeFreeBSD

Importing the xonsh shell into the FreeBSD ports tree.
AbandonedPublic

Authored by matthew on Nov 8 2016, 5:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 2:02 AM
Unknown Object (File)
Dec 10 2023, 4:50 AM
Unknown Object (File)
Nov 13 2023, 12:18 PM
Unknown Object (File)
Nov 12 2023, 11:43 PM
Unknown Object (File)
Nov 11 2023, 7:43 PM
Unknown Object (File)
Nov 10 2023, 4:12 PM
Unknown Object (File)
Nov 1 2023, 12:38 AM
Unknown Object (File)
Oct 25 2023, 8:27 AM

Details

Reviewers
larafercue_gmail.com
mat
Group Reviewers
Ports Committers
Summary

The xonsh shell is a Python-ish shell that can be
usefull for a developer, this patch is meant to importing the
software in the ports tree.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 5893
Build 6180: arc lint + arc unit

Event Timeline

larafercue_gmail.com retitled this revision from to Importing the xonsh shell into the FreeBSD ports tree..
larafercue_gmail.com updated this object.
larafercue_gmail.com edited the test plan for this revision. (Show Details)
mat requested changes to this revision.Nov 8 2016, 5:59 PM
mat added a reviewer: mat.
mat added inline comments.
shells/xonsh/Makefile
3–5

There are tabs missing after the = here.

9

This must be removed.

12

This is the default and can be removed.

14

the build and run are implied and can be removed.

shells/xonsh/pkg-descr
6

This should be:

WWW: http://xon.sh
This revision now requires changes to proceed.Nov 8 2016, 5:59 PM
larafercue_gmail.com edited edge metadata.

Modifying the patch with the changes indicated by mat.

larafercue_gmail.com edited edge metadata.

Removing the local changes to the xorg-server

shells/xonsh/Makefile
17

empty line

larafercue_gmail.com marked an inline comment as done.

Removing the empty line at the end of the Makefile as indicated by mat.

larafercue_gmail.com marked 5 inline comments as done.

Revision accepted, updated and setting the flag done to the revision comments.

This revision now requires changes to proceed.Jul 10 2017, 8:03 AM

Is there a PR for this?

I could not find any searching for it in bugzilla, so perhaps I forgot to open it. Should I open it?

In D8475#238957, @roberfern_gmail.com wrote:

Is there a PR for this?

I could not find any searching for it in bugzilla, so perhaps I forgot to open it. Should I open it?

You'ld have opened the PR is anyone did. Yes -- please open a PR and feel free to assign it to me. I'll take a look this evening.

matthew abandoned this revision.
matthew removed a reviewer: matthew.

This review has been superceeded by events, with the committal of shells/xonsh in r450378