Page MenuHomeFreeBSD

Importing the xonsh shell into the FreeBSD ports tree.
AbandonedPublic

Authored by matthew on Nov 8 2016, 5:08 PM.

Details

Reviewers
roberfern_gmail.com
mat
Group Reviewers
Ports Committers
Summary

The xonsh shell is a Python-ish shell that can be
usefull for a developer, this patch is meant to importing the
software in the ports tree.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6051
Build 6317: arc lint + arc unit

Event Timeline

roberfern_gmail.com retitled this revision from to Importing the xonsh shell into the FreeBSD ports tree..
roberfern_gmail.com updated this object.
roberfern_gmail.com edited the test plan for this revision. (Show Details)
mat requested changes to this revision.Nov 8 2016, 5:59 PM
mat added a reviewer: mat.
mat added inline comments.
shells/xonsh/Makefile
4–6

There are tabs missing after the = here.

10

This must be removed.

13

This is the default and can be removed.

15

the build and run are implied and can be removed.

shells/xonsh/pkg-descr
7

This should be:

WWW: http://xon.sh
This revision now requires changes to proceed.Nov 8 2016, 5:59 PM
roberfern_gmail.com edited edge metadata.

Modifying the patch with the changes indicated by mat.

roberfern_gmail.com edited edge metadata.

Removing the local changes to the xorg-server

mat added inline comments.Nov 23 2016, 4:26 PM
shells/xonsh/Makefile
17

empty line

roberfern_gmail.com marked an inline comment as done.

Removing the empty line at the end of the Makefile as indicated by mat.

roberfern_gmail.com marked 5 inline comments as done.

Revision accepted, updated and setting the flag done to the revision comments.

This revision now requires changes to proceed.Jul 10 2017, 8:03 AM

Is there a PR for this?

Is there a PR for this?

I could not find any searching for it in bugzilla, so perhaps I forgot to open it. Should I open it?

Is there a PR for this?

I could not find any searching for it in bugzilla, so perhaps I forgot to open it. Should I open it?

You'ld have opened the PR is anyone did. Yes -- please open a PR and feel free to assign it to me. I'll take a look this evening.

matthew commandeered this revision.Sep 23 2017, 2:16 PM
matthew abandoned this revision.
matthew removed a reviewer: matthew.

This review has been superceeded by events, with the committal of shells/xonsh in r450378