Differential D8407

Merge i.MX and PowerPC SDHCI drivers
ClosedPublic
Actions

Authored by jhibbits on Nov 1 2016, 3:57 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 18, 9:45 AM

	Unknown Object (File)
	Wed, Dec 4, 10:47 PM

	Unknown Object (File)
	Oct 1 2024, 12:17 AM

	Unknown Object (File)
	Oct 1 2024, 12:00 AM

	Unknown Object (File)
	Sep 27 2024, 2:39 PM

	Unknown Object (File)
	Sep 24 2024, 2:52 AM

	Unknown Object (File)
	Sep 19 2024, 1:28 PM

	Unknown Object (File)
	Sep 19 2024, 1:12 AM

View All 51 Files

Subscribers

Details

Reviewers

gonzo
imp
loos
adrian
• ian

Commits

rS308188: Merge i.MX and PowerPC SDHCI drivers

Summary

i.MX5 and PowerPC use a very similar eSDHC controller, which is also
similar to the uSDHC controller used by i.MX6. The imx_sdhci driver works
almost completely with PowerPC, with some minor tweaks.

There is one caveat with this: reset currently does not work on PowerPC, so has
been #ifdef'd out until this can be tracked down and fixed. If resets are done
the controller will timeout all data transactions. Without a reset, it appears
to work just fine.

Test Plan

This has been tested on a PowerPC QorIQ P1022 board. It has not been
tested on i.MX, but no regressions are expected.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5782
Build 6085: arc lint + arc unit

Event Timeline

jhibbits updated this revision to Diff 21866.Nov 1 2016, 3:57 AM

jhibbits retitled this revision from to Merge i.MX and PowerPC SDHCI drivers.

jhibbits updated this object.

jhibbits edited the test plan for this revision. (Show Details)

jhibbits added reviewers: • ian, adrian, gonzo, imp, loos.

Herald added a subscriber: andrew. · View Herald TranscriptNov 1 2016, 3:57 AM

Generally I like this. Please do the rename + s/imx/fsl/g in one commit, and the powerpc mods in the next commit, if possible. Thanks!

This revision is now accepted and ready to land.Nov 1 2016, 3:15 PM

Closed by commit rS308188: Merge i.MX and PowerPC SDHCI drivers (authored by jhibbits). · Explain WhyNov 2 2016, 12:57 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

arm/

freescale/

imx/

2 lines

2 lines

conf/

2 lines

dev/

sdhci/

1001 lines

9 lines

powerpc/

conf/

2 lines

2 lines

mpc85xx/

Diff 21866

sys/arm/freescale/imx/files.imx5

Loading...

sys/arm/freescale/imx/files.imx6

Loading...

sys/arm/freescale/imx/imx_sdhci.c

Loading...

sys/conf/files.powerpc

Loading...

sys/dev/sdhci/fsl_sdhci.c

Loading...

sys/dev/sdhci/sdhci.c

Loading...

sys/powerpc/conf/MPC85XX

Loading...

sys/powerpc/conf/MPC85XXSPE

Loading...

sys/powerpc/mpc85xx/fsl_sdhc.h

Loading...

sys/powerpc/mpc85xx/fsl_sdhc.c

Loading...