Build Clang on all architectures if host compiler supports C++11
ClosedPublic
Actions

Authored by emaste on Oct 17 2016, 2:00 PM.

Details

Reviewers

dim
imp

Commits

rS312776: Build Clang on all architectures if host compiler is C++11

Summary

Recent versions of Clang (3.8, 3.9) are starting to become usable for non-x86 non-arm FreeBSD architectures. If the compiler is capable of building Clang, do so in order to facilitate further testing.

(Perhaps we should just extend the test to add MIPS to powerpc instead, or change it to all but riscv and sparc64.)

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 21449.Oct 17 2016, 2:00 PM

emaste retitled this revision from to Build Clang on all architectures if host compiler supports C++11.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: dim, imp.

emaste added subscribers: br, adrian.

Herald added a subscriber: bdrewery. · View Herald TranscriptOct 17 2016, 2:00 PM

imp accepted this revision.Oct 17 2016, 4:29 PM

imp edited edge metadata.

This revision is now accepted and ready to land.Oct 17 2016, 4:29 PM

@dim OK for me to commit this to the clang400 branch?

LGTM.

Closed by commit rS312776: Build Clang on all architectures if host compiler is C++11 (authored by emaste). · Explain WhyJan 25 2017, 8:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

share/

mk/

src.opts.mk

4 lines

Diff 21449

View Options

share/mk/src.opts.mk

Show First 20 Lines • Show All 73 Lines • ▼ Show 20 Lines
#include "opt_vm.h"		#include "opt_vm.h"

#include <sys/param.h>		#include <sys/param.h>
#include <sys/bio.h>		#include <sys/bio.h>
#include <sys/blist.h>		#include <sys/blist.h>
#include <sys/buf.h>		#include <sys/buf.h>
#include <sys/conf.h>		#include <sys/conf.h>
#include <sys/disk.h>		#include <sys/disk.h>
		#include <sys/disklabel.h>
#include <sys/eventhandler.h>		#include <sys/eventhandler.h>
#include <sys/fcntl.h>		#include <sys/fcntl.h>
#include <sys/lock.h>		#include <sys/lock.h>
#include <sys/kernel.h>		#include <sys/kernel.h>
#include <sys/mount.h>		#include <sys/mount.h>
#include <sys/namei.h>		#include <sys/namei.h>
#include <sys/malloc.h>		#include <sys/malloc.h>
#include <sys/pctrie.h>		#include <sys/pctrie.h>
▲ Show 20 Lines • Show All 2,203 Lines • ▼ Show 20 Lines	swaponsomething(struct vnode vp, void id, u_long nblks,
sp->sw_nblks = nblks;		sp->sw_nblks = nblks;
sp->sw_used = 0;		sp->sw_used = 0;
sp->sw_strategy = strategy;		sp->sw_strategy = strategy;
sp->sw_close = close;		sp->sw_close = close;
sp->sw_flags = flags;		sp->sw_flags = flags;

sp->sw_blist = blist_create(nblks, M_WAITOK);		sp->sw_blist = blist_create(nblks, M_WAITOK);
/*		/*
* Do not free the first two block in order to avoid overwriting		* Do not free the first blocks in order to avoid overwriting
* any bsd label at the front of the partition		* any bsd label at the front of the partition
*/		*/
blist_free(sp->sw_blist, 2, nblks - 2);		blist_free(sp->sw_blist, howmany(BBSIZE, PAGE_SIZE),
		nblks - howmany(BBSIZE, PAGE_SIZE));

		alcUnsubmitted Not Done Inline Actions Consider the possibility that PAGE_SIZE is greater than BBSIZE. (We still barely support one architecture, sparc64, where they are equal.) I think that howmany(BBSIZE, PAGE_SIZE) will "do the right thing." alc: Consider the possibility that PAGE_SIZE is greater than BBSIZE. (We still barely support one…
dvbase = 0;		dvbase = 0;
mtx_lock(&sw_dev_mtx);		mtx_lock(&sw_dev_mtx);
TAILQ_FOREACH(tsp, &swtailq, sw_list) {		TAILQ_FOREACH(tsp, &swtailq, sw_list) {
if (tsp->sw_end >= dvbase) {		if (tsp->sw_end >= dvbase) {
/*		/*
* We put one uncovered page between the devices		* We put one uncovered page between the devices
* in order to definitively prevent any cross-device		* in order to definitively prevent any cross-device
* I/O requests		* I/O requests
*/		*/
dvbase = tsp->sw_end + 1;		dvbase = tsp->sw_end + 1;
}		}
}		}
sp->sw_first = dvbase;		sp->sw_first = dvbase;
sp->sw_end = dvbase + nblks;		sp->sw_end = dvbase + nblks;
TAILQ_INSERT_TAIL(&swtailq, sp, sw_list);		TAILQ_INSERT_TAIL(&swtailq, sp, sw_list);
nswapdev++;		nswapdev++;
swap_pager_avail += nblks - 2;		swap_pager_avail += nblks - howmany(BBSIZE, PAGE_SIZE);
		alcUnsubmitted Not Done Inline Actions This should also use howmany(BBSIZE, PAGE_SIZE). alc: This should also use howmany(BBSIZE, PAGE_SIZE).
swap_total += nblks;		swap_total += nblks;
swapon_check_swzone();		swapon_check_swzone();
swp_sizecheck();		swp_sizecheck();
mtx_unlock(&sw_dev_mtx);		mtx_unlock(&sw_dev_mtx);
EVENTHANDLER_INVOKE(swapon, sp);		EVENTHANDLER_INVOKE(swapon, sp);
}		}

/*		/*
▲ Show 20 Lines • Show All 661 Lines • Show Last 20 Lines

Build Clang on all architectures if host compiler supports C++11ClosedPublicActions