Page MenuHomeFreeBSD
Differential D8174

jedec_ts: a driver for temperature sensors on memory modules
ClosedPublic
Actions

Authored by avg on Oct 7 2016, 8:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 4 2024, 10:09 AM
Unknown Object (File)
Dec 4 2024, 10:09 AM
Unknown Object (File)
Dec 4 2024, 10:09 AM
Unknown Object (File)
Dec 4 2024, 10:09 AM
Unknown Object (File)
Dec 4 2024, 9:48 AM
Unknown Object (File)
Oct 5 2024, 5:23 AM
Unknown Object (File)
Sep 19 2024, 12:09 AM
Unknown Object (File)
Sep 11 2024, 6:49 PM
View All Files
Subscribers
wblock

Details

Reviewers
jhb
wblock
imp
Group Reviewers
manpages
Commits
rS307768: jedec_ts: a driver for thermal sensors on memory modules
Summary

The driver currently supports chips that are fully compliant with the
JEDEC SPD / EEPROM / TS standard (JEDEC Standard 21-C,
TSE2002 Specification, frequenlty referred to as JEDEC JC 42.4).

Additionally some chips from STMicroelectronics are supported as well.
They are compliant except for their Device ID pattern.

Test Plan

Tested on hardware that I have access to:
KVR16E11S8/4 memory modules with STTS424E02 chip (compines a temperature
sensor and an SPD EEPROM).
Example:
dev.jedec_ts.0.temp: 39.2500C

Diff Detail

Event Timeline

avg updated this revision to Diff 21137.Oct 7 2016, 8:13 AM
avg retitled this revision from to jedec_ts: a driver for temperature sensors on memory modules.
avg updated this object.
avg edited the test plan for this revision. (Show Details)
avg added reviewers: imp, jhb.
Herald added a reviewer: manpages. · View Herald TranscriptOct 7 2016, 8:13 AM
avg added a parent revision: D8173: smbus: allow child devices to be added via hints.Oct 7 2016, 8:14 AM
imp added inline comments.Oct 8 2016, 4:24 AM
sys/dev/jedec_ts/jedec_ts.c
103

It would be safer to put all this in the attach routine.
Most of the I2C drivers just assume the probe is good.
There are a few that write to the chip during the probe.

avg added inline comments.Oct 10 2016, 2:08 PM
sys/dev/jedec_ts/jedec_ts.c
103

Is this to avoid fiddling with the hardware in case that a more specific driver wins the device during probing?
I'll make the change.

avg updated this revision to Diff 21293.Oct 12 2016, 7:03 AM
avg edited edge metadata.

jedec_ts: move hardware probing to the attach routine

This is done, so that another, more specific driver could claim
the device before this driver has a chance to mess up the hardware.

Herald edited edge metadata. · View Herald TranscriptOct 12 2016, 7:03 AM
avg marked 2 inline comments as done.Oct 12 2016, 7:30 AM
avg updated this revision to Diff 21342.Oct 13 2016, 6:40 AM
avg edited edge metadata.
  • actually allow to be compiled into the kernel
  • add to NOTES / LINT
  • some clean-ups in the manual page
Herald edited edge metadata. · View Herald TranscriptOct 13 2016, 6:40 AM
wblock added a subscriber: wblock.Oct 14 2016, 3:09 PM
wblock added inline comments.
share/man/man4/jedec_ts.4
80

Not sure if .Va should be included in the parameter as it is invisible, but at worst it just gives an extra three spaces of indent.

86

Needs a comma:

.Xr device.hints 5 ,
100

Generally, numbers less than ten should be spelled out.

101

As above, s/8/eight/.

avg updated this revision to Diff 21415.Oct 15 2016, 9:25 AM
avg edited edge metadata.

man page fixes suggested by wblock

Herald edited edge metadata. · View Herald TranscriptOct 15 2016, 9:25 AM
avg marked 4 inline comments as done.Oct 15 2016, 9:26 AM
wblock accepted this revision.Oct 16 2016, 5:38 PM
wblock added a reviewer: wblock.

Man page looks good, but please test with mandoc -Tlint and igor -Rbefore commit. Thanks!

This revision is now accepted and ready to land.Oct 16 2016, 5:38 PM
avg updated this revision to Diff 21438.Oct 17 2016, 7:39 AM
avg edited edge metadata.

add jedec_ts to modules/i2c/Makefile

This revision now requires review to proceed.Oct 17 2016, 7:39 AM
avg added a comment.Oct 17 2016, 7:40 AM

If there are no objections or requests for changes, I would like to commit this driver sooner rather than later.

Closed by commit rS307768: jedec_ts: a driver for thermal sensors on memory modules (authored by avg). · Explain WhyOct 22 2016, 8:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
131 lines
sys/
dev/
jedec_ts/
179 lines
modules/
i2c/
jedec_ts/
7 lines

Diff 21137

View Options

share/man/man4/jedec_ts.4

Loading...
View Options

sys/dev/jedec_ts/

Loading...
View Options

sys/dev/jedec_ts/jedec_ts.c

Loading...
View Options

sys/modules/i2c/jedec_ts/

Loading...
View Options

sys/modules/i2c/jedec_ts/Makefile

Loading...