groff: use changelog date rather than file modification date in man pages
ClosedPublic
Actions

Authored by emaste on Oct 5 2016, 9:23 PM.

Details

Reviewers

allanjude
bapt
cperciva

Commits

rS306740: groff: use changelog date rather than file modification date in man pages

Summary

The source checkout date is not particularly relevant, and this makes groff man pages build reproducibly.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 21087.Oct 5 2016, 9:23 PM

emaste retitled this revision from to groff: use changelog date rather than file modification date in man pages.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: bapt, cperciva, allanjude.

emaste added a subscriber: gjb.

bapt accepted this revision.Oct 5 2016, 9:27 PM

bapt edited edge metadata.

This revision is now accepted and ready to land.Oct 5 2016, 9:27 PM

Is there a reason to generate $MDATE via != rather than simply changing the backtick execution within the sed command?

In D8158#169212, @cperciva wrote:

Is there a reason to generate $MDATE via != rather than simply changing the backtick execution within the sed command?

I prefer it for easier debugging the Makefile, and for being clear that it's only being evaluated once per use of Makefile.inc. Because we're going to use one date in common for all manpages there's no need for per-file checking.

Closed by commit rS306740: groff: use changelog date rather than file modification date in man pages (authored by emaste). · Explain WhyOct 5 2016, 11:25 PM

This revision was automatically updated to reflect the committed changes.