Page MenuHomeFreeBSD
Differential D7988

dma-mbox-create: Restrict with Capsicum
ClosedPublic
Actions

Authored by cem on Sep 21 2016, 5:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 3:03 PM
Unknown Object (File)
Mar 8 2024, 10:57 PM
Unknown Object (File)
Mar 8 2024, 10:57 PM
Unknown Object (File)
Mar 8 2024, 10:57 PM
Unknown Object (File)
Mar 8 2024, 10:57 PM
Unknown Object (File)
Mar 8 2024, 10:57 PM
Unknown Object (File)
Mar 8 2024, 10:57 PM
Unknown Object (File)
Mar 7 2024, 9:36 PM
View All Files
Subscribers
imp
lifanov_mail.lifanov.com

Details

Reviewers
emaste
allanjude
oshogbo
Commits
rS310140: dma-mbox-create: Restrict with Capsicum
Summary

The restriction here is pretty late and pretty minimal. We need a lot
of authority to open password databases, and don't do much after that
point.

Test Plan
  • sudo truss /usr/libexec/dma-mbox-create cmeyer

Diff Detail

Event Timeline

cem updated this revision to Diff 20566.Sep 21 2016, 5:32 AM
cem retitled this revision from to dma-mbox-create: Restrict with Capsicum.
cem updated this object.
cem edited the test plan for this revision. (Show Details)
cem added reviewers: emaste, allanjude, oshogbo.
Herald added a subscriber: imp. · View Herald TranscriptSep 21 2016, 5:32 AM
lifanov_mail.lifanov.com added a subscriber: lifanov_mail.lifanov.com.Sep 21 2016, 6:12 PM

Hi! Do we want to ifdef the capsicum part? We share this code with DragonFly, https://github.com/corecode/dma (which is where our port comes from), and the latter is used in Debian. I also pull this code and build it for CentOS.

emaste edited edge metadata.Sep 21 2016, 6:20 PM
In D7988#165295, @lifanov_mail.lifanov.com wrote:

Hi! Do we want to ifdef the capsicum part? We share this code with DragonFly, https://github.com/corecode/dma (which is where our port comes from), and the latter is used in Debian. I also pull this code and build it for CentOS.

It's definitely best if we can share an unmodified version of this with other operating systems, so #ifdefing the Capsicum-specific chagnes seems reasonable to me.

cem added a comment.Sep 21 2016, 6:21 PM

Easily done!

emaste added a comment.Sep 21 2016, 6:26 PM

FYI we #ifdef'd bspatch as FreeBSD is upstream and other software may pull from us,
https://svnweb.freebsd.org/base/head/usr.bin/bsdiff/bspatch/bspatch.c?view=markup
having the small refactoring here (the maildirfd) upstream should be useful in other operating systems with some sandboxing technology

cem updated this revision to Diff 20584.Sep 21 2016, 6:26 PM
cem edited edge metadata.

Ifdef Capsicum support (FreeBSD-only for now) for code-sharing with DragonFly
and Linux.

cem added a comment.Sep 21 2016, 6:27 PM
In D7988#165300, @emaste wrote:

FYI we #ifdef'd bspatch as FreeBSD is upstream and other software may pull from us,
https://svnweb.freebsd.org/base/head/usr.bin/bsdiff/bspatch/bspatch.c?view=markup
having the small refactoring here (the maildirfd) upstream should be useful in other operating systems with some sandboxing technology

Right. Most of these changes are not FreeBSD-specific, so I only ifdef'd the Capsicum-exclusive bits.

emaste added inline comments.Sep 29 2016, 9:26 PM
contrib/dma/dma-mbox-create.c
168–175

do we still need fn?
I think it would be fine to print just the user (e.g. open mbox for user '%s'", or if we want the path do %s/%s.

emaste added a comment.Sep 29 2016, 9:28 PM

Considering sending this as a pull request for upstream: https://github.com/emaste/dma/commit/6748bdd435e6287cb36ea278fec2a1f7281be6bf

cem added a comment.Sep 29 2016, 9:32 PM
In D7988#167172, @emaste wrote:

Considering sending this as a pull request for upstream: https://github.com/emaste/dma/commit/6748bdd435e6287cb36ea278fec2a1f7281be6bf

Yeah, that looks fine to me. Go ahead. (Can you CC me on the PR?)

cem updated this revision to Diff 20896.Oct 1 2016, 12:07 AM

Rebase over Ed's maildirfd patch.

cem updated this revision to Diff 22075.Nov 8 2016, 5:49 AM

Use capsicum helpers for tz and nls caching.

cem added a comment.Dec 9 2016, 4:32 PM

Is this too useless to commit? Nothing beyond sandbox entry seems even remotely exploitable.

Closed by commit rS310140: dma-mbox-create: Restrict with Capsicum (authored by cem). · Explain WhyDec 16 2016, 1:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
contrib/
dma/
38 lines

Diff 20566

View Options

contrib/dma/dma-mbox-create.c

Loading...