Page MenuHomeFreeBSD
Differential D7965

Deliver SIGTRAP when ENOTCAPABLE error is returned from a syscall for the process in capability mode.
ClosedPublic
Actions

Authored by kib on Sep 20 2016, 9:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 5, 4:31 PM
Unknown Object (File)
Tue, Apr 1, 12:09 PM
Unknown Object (File)
Thu, Mar 13, 10:21 PM
Unknown Object (File)
Feb 21 2025, 3:27 PM
Unknown Object (File)
Feb 21 2025, 3:00 PM
Unknown Object (File)
Feb 20 2025, 3:05 AM
Unknown Object (File)
Feb 18 2025, 6:53 PM
Unknown Object (File)
Feb 16 2025, 9:22 PM
View All 98 Files
Subscribers
imp

Details

Reviewers
kib
emaste
bapt
oshogbo
Commits
rS306081: Add PROC_TRAPCAP procctl(2) controls and global sysctl kern.trap_enocap.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 5235
Build 5384: CI src buildJenkins

Event Timeline

kib updated this revision to Diff 20523.Sep 20 2016, 9:36 AM
kib retitled this revision from to Deliver SIGTRAP when ENOTCAPABLE error is returned from a syscall for the process in capability mode..
kib updated this object.
kib edited the test plan for this revision. (Show Details)
kib added reviewers: emaste, bapt, oshogbo.
kib set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptSep 20 2016, 9:36 AM
oshogbo accepted this revision.Sep 20 2016, 9:39 AM
oshogbo edited edge metadata.

That's very cool idea.

This revision is now accepted and ready to land.Sep 20 2016, 9:39 AM
kib added a comment.Sep 20 2016, 9:45 AM
In D7965#164786, @oshogbo wrote:

That's very cool idea.

By emaste'.

emaste accepted this revision.Sep 20 2016, 1:57 PM
emaste edited edge metadata.

Possible enhancements include being able to set this on a per-process basis, and allowing other than SIGTRAP, but this solves my immediate use case.

kib updated this revision to Diff 20542.Sep 20 2016, 4:02 PM
kib edited edge metadata.

Add procctl(2) knob to enable trapping behavior only for subtree.
Treat ECAPMODE same as ENOTCAPABLE.

This revision now requires review to proceed.Sep 20 2016, 4:02 PM
emaste added inline comments.Sep 20 2016, 5:20 PM
sys/kern/subr_syscall.c
182

ksi.ksi_errno = error1;?

kib accepted this revision.Sep 20 2016, 5:25 PM
kib added a reviewer: kib.
kib marked an inline comment as done.
This revision is now accepted and ready to land.Sep 20 2016, 5:25 PM
kib updated this revision to Diff 20547.Sep 20 2016, 5:27 PM
kib edited edge metadata.

Report actual error in siginfo, it is not neccessary ENOTCAPABLE now.

This revision now requires review to proceed.Sep 20 2016, 5:27 PM
emaste accepted this revision.Sep 20 2016, 5:32 PM
emaste edited edge metadata.
This revision is now accepted and ready to land.Sep 20 2016, 5:32 PM
Closed by commit rS306081: Add PROC_TRAPCAP procctl(2) controls and global sysctl kern.trap_enocap. (authored by kib). · Explain WhySep 21 2016, 8:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
compat/
freebsd32/
3 lines
kern/
2 lines
38 lines
15 lines
4 lines
sys/
2 lines
1 line
5 lines
1 line

Diff 20542

View Options

sys/compat/freebsd32/freebsd32_misc.c

  • This file was added.
PropertyOld ValueNew Value
svn:eol-stylenullnative
\ No newline at end of property
svn:keywordsnullFreeBSD=%H
\ No newline at end of property
svn:mime-typenulltext/plain
\ No newline at end of property
# $FreeBSD$
PORTNAME= mping
DISTVERSION= 0.1.3
CATEGORIES= sysutils
MAINTAINER= dteske@FreeBSD.org
COMMENT= Ping multiple hosts
LICENSE= BSD2CLAUSE
LICENSE_FILE= ${WRKSRC}/LICENSE
USE_GITHUB= yes
GH_ACCOUNT= FrauBSD
NO_ARCH= yes
NO_BUILD= yes
PLIST_FILES= bin/mping
PORTDOCS= README.md
OPTIONS_DEFINE= DOCS
do-install:
${INSTALL_SCRIPT} ${WRKSRC}/mping ${STAGEDIR}${PREFIX}/bin
baptUnsubmitted
Done
Inline Actions

Why this line, I don't think it is actually needed

bapt: Why this line, I don't think it is actually needed
do-install-DOCS-on:
@${MKDIR} ${STAGEDIR}${DOCSDIR}
baptUnsubmitted
Done
Inline Actions

This is not needed as well, automatically created by the mtree file when creating the stage directory

bapt: This is not needed as well, automatically created by the mtree file when creating the stage…
${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
.include <bsd.port.mk>
View Options

sys/kern/kern_fork.c

  • This file was added.
PropertyOld ValueNew Value
svn:eol-stylenullnative
\ No newline at end of property
svn:keywordsnullFreeBSD=%H
\ No newline at end of property
svn:mime-typenulltext/plain
\ No newline at end of property
# $FreeBSD$
PORTNAME= mping
DISTVERSION= 0.1.3
CATEGORIES= sysutils
MAINTAINER= dteske@FreeBSD.org
COMMENT= Ping multiple hosts
LICENSE= BSD2CLAUSE
LICENSE_FILE= ${WRKSRC}/LICENSE
USE_GITHUB= yes
GH_ACCOUNT= FrauBSD
NO_ARCH= yes
NO_BUILD= yes
PLIST_FILES= bin/mping
PORTDOCS= README.md
OPTIONS_DEFINE= DOCS
do-install:
${INSTALL_SCRIPT} ${WRKSRC}/mping ${STAGEDIR}${PREFIX}/bin
baptUnsubmitted
Done
Inline Actions

Why this line, I don't think it is actually needed

bapt: Why this line, I don't think it is actually needed
do-install-DOCS-on:
@${MKDIR} ${STAGEDIR}${DOCSDIR}
baptUnsubmitted
Done
Inline Actions

This is not needed as well, automatically created by the mtree file when creating the stage directory

bapt: This is not needed as well, automatically created by the mtree file when creating the stage…
${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
.include <bsd.port.mk>
View Options

sys/kern/kern_procctl.c

  • This file was added.
PropertyOld ValueNew Value
svn:eol-stylenullnative
\ No newline at end of property
svn:keywordsnullFreeBSD=%H
\ No newline at end of property
svn:mime-typenulltext/plain
\ No newline at end of property
# $FreeBSD$
PORTNAME= mping
DISTVERSION= 0.1.3
CATEGORIES= sysutils
MAINTAINER= dteske@FreeBSD.org
COMMENT= Ping multiple hosts
LICENSE= BSD2CLAUSE
LICENSE_FILE= ${WRKSRC}/LICENSE
USE_GITHUB= yes
GH_ACCOUNT= FrauBSD
NO_ARCH= yes
NO_BUILD= yes
PLIST_FILES= bin/mping
PORTDOCS= README.md
OPTIONS_DEFINE= DOCS
do-install:
${INSTALL_SCRIPT} ${WRKSRC}/mping ${STAGEDIR}${PREFIX}/bin
baptUnsubmitted
Done
Inline Actions

Why this line, I don't think it is actually needed

bapt: Why this line, I don't think it is actually needed
do-install-DOCS-on:
@${MKDIR} ${STAGEDIR}${DOCSDIR}
baptUnsubmitted
Done
Inline Actions

This is not needed as well, automatically created by the mtree file when creating the stage directory

bapt: This is not needed as well, automatically created by the mtree file when creating the stage…
${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
.include <bsd.port.mk>
View Options

sys/kern/subr_syscall.c

  • This file was added.
PropertyOld ValueNew Value
svn:eol-stylenullnative
\ No newline at end of property
svn:keywordsnullFreeBSD=%H
\ No newline at end of property
svn:mime-typenulltext/plain
\ No newline at end of property
# $FreeBSD$
PORTNAME= mping
DISTVERSION= 0.1.3
CATEGORIES= sysutils
MAINTAINER= dteske@FreeBSD.org
COMMENT= Ping multiple hosts
LICENSE= BSD2CLAUSE
LICENSE_FILE= ${WRKSRC}/LICENSE
USE_GITHUB= yes
GH_ACCOUNT= FrauBSD
NO_ARCH= yes
NO_BUILD= yes
PLIST_FILES= bin/mping
PORTDOCS= README.md
OPTIONS_DEFINE= DOCS
do-install:
${INSTALL_SCRIPT} ${WRKSRC}/mping ${STAGEDIR}${PREFIX}/bin
baptUnsubmitted
Done
Inline Actions

Why this line, I don't think it is actually needed

bapt: Why this line, I don't think it is actually needed
do-install-DOCS-on:
@${MKDIR} ${STAGEDIR}${DOCSDIR}
baptUnsubmitted
Done
Inline Actions

This is not needed as well, automatically created by the mtree file when creating the stage directory

bapt: This is not needed as well, automatically created by the mtree file when creating the stage…
${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
.include <bsd.port.mk>
View Options

sys/kern/sys_capability.c

Loading...
View Options

sys/sys/capsicum.h

Loading...
View Options

sys/sys/proc.h

Loading...
View Options

sys/sys/procctl.h

Loading...
View Options

sys/sys/signal.h

Loading...