Paths

Table of Contentst

tr(1): Capsicumify
ClosedPublic
Actions

Authored by cem on Sep 18 2016, 9:11 AM.

Details

Reviewers

emaste
allanjude
bapt
ache

Commits

rS305982: tr(1): Capsicumify

Summary

This is a straightforward single input, single output program for
capsicum.

Test Plan

tr abc ddd (tty input)
echo abcdef | tr abc ddd
echo abcdef | LANG=ko_KR.UTF-8 tr "[:lower:]" "[:upper:]"

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem updated this revision to Diff 20431.Sep 18 2016, 9:11 AM

cem retitled this revision from to tr(1): Capsicumify.

cem updated this object.

cem edited the test plan for this revision. (Show Details)

cem added reviewers: allanjude, emaste, ache.

Herald added a subscriber: imp. · View Herald TranscriptSep 18 2016, 9:11 AM

What about stderr?
for stdin you probably want to check EBADF because STDIN can be closed

bapt accepted this revision.Sep 18 2016, 4:38 PM

bapt added a reviewer: bapt.

This revision is now accepted and ready to land.Sep 18 2016, 4:38 PM

In D7928#164224, @bapt wrote:

What about stderr?

Sure.

for stdin you probably want to check EBADF because STDIN can be closed

I guess it *can* be closed. But that's kind of a silly thing for someone to do before executing tr. Do we care?

Restrict stderr too.

This revision now requires review to proceed.Sep 18 2016, 5:29 PM

bapt accepted this revision.Sep 18 2016, 5:41 PM

bapt edited edge metadata.

This revision is now accepted and ready to land.Sep 18 2016, 5:41 PM

Closed by commit rS305982: tr(1): Capsicumify (authored by cem). · Explain WhySep 19 2016, 4:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

tr/

tr.c

26 lines

Diff 20492

View Options

tr(1): CapsicumifyClosedPublicActions