Page MenuHomeFreeBSD

tr(1): Capsicumify
ClosedPublic

Authored by cem on Sep 18 2016, 9:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 20 2024, 1:05 PM
Unknown Object (File)
Oct 8 2024, 3:46 PM
Unknown Object (File)
Sep 23 2024, 8:19 PM
Unknown Object (File)
Sep 21 2024, 11:54 AM
Unknown Object (File)
Sep 21 2024, 11:53 AM
Unknown Object (File)
Sep 21 2024, 11:53 AM
Unknown Object (File)
Sep 21 2024, 11:52 AM
Unknown Object (File)
Sep 16 2024, 6:25 PM
Subscribers

Details

Summary

This is a straightforward single input, single output program for
capsicum.

Test Plan
  • tr abc ddd (tty input)
  • echo abcdef | tr abc ddd
  • echo abcdef | LANG=ko_KR.UTF-8 tr "[:lower:]" "[:upper:]"

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cem retitled this revision from to tr(1): Capsicumify.
cem updated this object.
cem edited the test plan for this revision. (Show Details)
cem added reviewers: allanjude, emaste, ache.

What about stderr?
for stdin you probably want to check EBADF because STDIN can be closed

bapt added a reviewer: bapt.
This revision is now accepted and ready to land.Sep 18 2016, 4:38 PM
In D7928#164224, @bapt wrote:

What about stderr?

Sure.

for stdin you probably want to check EBADF because STDIN can be closed

I guess it *can* be closed. But that's kind of a silly thing for someone to do before executing tr. Do we care?

cem edited edge metadata.

Restrict stderr too.

This revision now requires review to proceed.Sep 18 2016, 5:29 PM
bapt edited edge metadata.
This revision is now accepted and ready to land.Sep 18 2016, 5:41 PM
This revision was automatically updated to reflect the committed changes.