Page MenuHomeFreeBSD
Differential D7928

tr(1): Capsicumify
ClosedPublic
Actions

Authored by cem on Sep 18 2016, 9:11 AM.
Tags
None
Referenced Files
F119265006: D7928.id20461.diff
Sat, Jun 7, 1:01 AM
Unknown Object (File)
Tue, Jun 3, 7:19 PM
Unknown Object (File)
Sun, Jun 1, 7:25 AM
Unknown Object (File)
Sat, May 31, 8:58 AM
Unknown Object (File)
Wed, May 28, 10:58 PM
Unknown Object (File)
Fri, May 16, 7:42 AM
Unknown Object (File)
Apr 25 2025, 6:15 AM
Unknown Object (File)
Apr 24 2025, 10:02 PM
View All 78 Files
Subscribers
bapt
imp

Details

Reviewers
emaste
allanjude
bapt
ache
Commits
rS305982: tr(1): Capsicumify
Summary

This is a straightforward single input, single output program for
capsicum.

Test Plan
  • tr abc ddd (tty input)
  • echo abcdef | tr abc ddd
  • echo abcdef | LANG=ko_KR.UTF-8 tr "[:lower:]" "[:upper:]"

Diff Detail

Event Timeline

cem updated this revision to Diff 20431.Sep 18 2016, 9:11 AM
cem retitled this revision from to tr(1): Capsicumify.
cem updated this object.
cem edited the test plan for this revision. (Show Details)
cem added reviewers: allanjude, emaste, ache.
Herald added a subscriber: imp. · View Herald TranscriptSep 18 2016, 9:11 AM
bapt added a subscriber: bapt.Sep 18 2016, 10:59 AM

What about stderr?
for stdin you probably want to check EBADF because STDIN can be closed

bapt accepted this revision.Sep 18 2016, 4:38 PM
bapt added a reviewer: bapt.
This revision is now accepted and ready to land.Sep 18 2016, 4:38 PM
cem added a comment.Sep 18 2016, 5:27 PM
In D7928#164224, @bapt wrote:

What about stderr?

Sure.

for stdin you probably want to check EBADF because STDIN can be closed

I guess it *can* be closed. But that's kind of a silly thing for someone to do before executing tr. Do we care?

cem updated this revision to Diff 20461.Sep 18 2016, 5:29 PM
cem edited edge metadata.

Restrict stderr too.

This revision now requires review to proceed.Sep 18 2016, 5:29 PM
bapt accepted this revision.Sep 18 2016, 5:41 PM
bapt edited edge metadata.
This revision is now accepted and ready to land.Sep 18 2016, 5:41 PM
Closed by commit rS305982: tr(1): Capsicumify (authored by cem). · Explain WhySep 19 2016, 4:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.bin/
tr/
26 lines

Diff 20461

View Options

usr.bin/tr/tr.c

Loading...