Page MenuHomeFreeBSD
Differential D7936

Capsicumize soelim(1)
ClosedPublic
Actions

Authored by bapt on Sep 18 2016, 10:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 5:32 PM
Unknown Object (File)
Thu, Apr 10, 11:28 PM
Unknown Object (File)
Mar 9 2025, 7:37 AM
Unknown Object (File)
Feb 20 2025, 3:06 PM
Unknown Object (File)
Feb 18 2025, 7:32 AM
Unknown Object (File)
Jan 26 2025, 4:15 AM
Unknown Object (File)
Jan 16 2025, 9:06 AM
Unknown Object (File)
Jan 15 2025, 3:27 PM
View All Files
Subscribers
imp

Details

Reviewers
emaste
cem
allanjude
oshogbo
Commits
rS305936: Capsicum-ize soelim(1).
Summary

Given it expects multiple files in arguments, open / first and then only
usr openat to open the various files.

In order to include files in the current directory we add it to the list of
includes in first argument

Test Plan

Passes the testsuite

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bapt updated this revision to Diff 20440.Sep 18 2016, 10:49 AM
bapt retitled this revision from to Capsicumize soelim(1).
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added reviewers: oshogbo, emaste, allanjude, cem.
Herald added a subscriber: imp. · View Herald TranscriptSep 18 2016, 10:49 AM
bapt updated this revision to Diff 20441.Sep 18 2016, 10:51 AM

Close the fd on / when exiting

bapt updated this revision to Diff 20443.Sep 18 2016, 11:18 AM

Fix typo in error message

bapt mentioned this in D7918: ident(1): Capsicumify.Sep 18 2016, 12:24 PM
allanjude accepted this revision.Sep 18 2016, 4:17 PM
allanjude edited edge metadata.

looks good to me. Might be able to be improved once casper has filesystem services

This revision is now accepted and ready to land.Sep 18 2016, 4:17 PM
Closed by commit rS305936: Capsicum-ize soelim(1). (authored by bapt). · Explain WhySep 18 2016, 4:25 PM
This revision was automatically updated to reflect the committed changes.
oshogbo added inline comments.Sep 18 2016, 5:51 PM
head/usr.bin/soelim/soelim.c
60

Style should be one free line if there is no variables.

78

Can fail.

89

Can fail.

159

getcwd - can fail.

197

Can fail.

oshogbo added inline comments.Sep 18 2016, 5:56 PM
head/usr.bin/soelim/soelim.c
187

Dot on the on of the comment ;P

Revision Contents
Changeset List

PathSize
head/
usr.bin/
soelim/
70 lines

Diff 20458

View Options

head/usr.bin/soelim/soelim.c

Show All 28 Lines
.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT .\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY .\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
.\" SUCH DAMAGE. .\" SUCH DAMAGE.
.\" .\"
.\" From: @(#)tcp.4 8.1 (Berkeley) 6/5/93 .\" From: @(#)tcp.4 8.1 (Berkeley) 6/5/93
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd October 7, 2022 .Dd October 13, 2022
.Dt TCP 4 .Dt TCP 4
.Os .Os
.Sh NAME .Sh NAME
.Nm tcp .Nm tcp
.Nd Internet Transmission Control Protocol .Nd Internet Transmission Control Protocol
.Sh SYNOPSIS .Sh SYNOPSIS
.In sys/types.h .In sys/types.h
.In sys/socket.h .In sys/socket.h
▲ Show 20 Lines • Show All 459 Lines • ▼ Show 20 Lines
Outgoing connections will request ECN. Outgoing connections will request ECN.
.It 2 .It 2
Allow incoming connections to request ECN. Allow incoming connections to request ECN.
Outgoing connections will not request ECN. Outgoing connections will not request ECN.
(default) (default)
.It 3 .It 3
Negotiate on incoming connection for Accurate ECN, ECN, or no ECN. Negotiate on incoming connection for Accurate ECN, ECN, or no ECN.
Outgoing connections will request Accurate ECN and fall back to Outgoing connections will request Accurate ECN and fall back to
ECN depending on the capabilities of the server. ECN depending on the capabilities of the remote host.
pauamma_gundo.comUnsubmitted
Done
Inline Actions
Outgoing connections will request Accurate ECN and fall back to
- ECN depending on the capabilities of the server.
+ ECN depending on the capabilities of the remote host.
.It 4
pauamma_gundo.com:
.It 4 .It 4
Negotiate on incoming connection for Accurate ECN, ECN, or no ECN. Negotiate on incoming connection for Accurate ECN, ECN, or no ECN.
Outgoing connections will not request ECN. Outgoing connections will not request ECN.
.El
.It Va ecn.generalized
Enable sending all segments as ECN capable transport,
including SYN, SYN/ACK, and retransmissions.
This may only be enabled when ECN support itself is also active.
Disabling ECN support will disable this feature automatically.
Settings:
.Bl -tag -compact
.It 0
Regular RFC3168 operation.
Send only new data segments as ECN capable transport.
(default)
.It 1
Support generalized ECN (ECN++), and send all segments of an ECN-enabled
session as ECN capable transport.
Also control packets to non-established and non-listening ports are
identically marked, if outgoing sessions would request ECN.
.El .El
.It Va ecn.maxretries .It Va ecn.maxretries
Number of retries (SYN or SYN/ACK retransmits) before disabling ECN on a Number of retries (SYN or SYN/ACK retransmits) before disabling ECN on a
specific connection. specific connection.
This is needed to help with connection establishment This is needed to help with connection establishment
when a broken firewall is in the network path. when a broken firewall is in the network path.
.It Va fast_finwait2_recycle .It Va fast_finwait2_recycle
Recycle Recycle
.Tn TCP .Tn TCP
.Dv FIN_WAIT_2 .Dv FIN_WAIT_2
pauamma_gundo.comUnsubmitted
Done
Inline Actions
including SYN, SYN/ACK, and retransmissions.
- This may only be enabled, when ECN support itself is also active.
+ This may only be enabled when ECN support itself is also active.
Disabling ECN support will disable this feature automatically.
pauamma_gundo.com:
connections faster when the socket is marked as connections faster when the socket is marked as
.Dv SBS_CANTRCVMORE .Dv SBS_CANTRCVMORE
(no user process has the socket open, data received on (no user process has the socket open, data received on
the socket cannot be read). the socket cannot be read).
The timeout used here is The timeout used here is
.Va finwait2_timeout . .Va finwait2_timeout .
.It Va fastopen.acceptany .It Va fastopen.acceptany
pauamma_gundo.comUnsubmitted
Done
Inline Actions
Regular RFC3168 operation.
- Send only new data segements as ECN capable transport.
- (default)
+ Send only new data segments as ECN capable transport (default).
.It 1

Typo and move full stop to a more natural place.

pauamma_gundo.com: Typo and move full stop to a more natural place.
When non-zero, all client-supplied TFO cookies will be considered to be valid. When non-zero, all client-supplied TFO cookies will be considered to be valid.
The default is 0. The default is 0.
.It Va fastopen.autokey .It Va fastopen.autokey
When this and When this and
.Va net.inet.tcp.fastopen.server_enable .Va net.inet.tcp.fastopen.server_enable
bcrUnsubmitted
Done
Inline Actions

s/identially/identically/

bcr: s/identially/identically/
pauamma_gundo.comUnsubmitted
Done
Inline Actions

Can you explain what you mean by that? I'm arguably not the indended audience, but if I don't understand it, there's a chance some of the intended audience and or some interested readers won't either.

pauamma_gundo.com: Can you explain what you mean by that? I'm arguably not the indended audience, but if I don't…
rscheffAuthorUnsubmitted
Done
Inline Actions

When a host receives a TCP packet to a port which is not listening, or no connection exists, or the header information is in some other way not acceptable, the host may respond with a RST (reset) packet. Some of these RST packets are sent from "regular" TCP processing (e.g. outside the sequence window) and others from non-open ports. Making these distinctable by carrying different markings - depending which code path was sending them - would give clues as to what ports/services may be reachable, and give rise to more targetted attacks.
As part if this change, when introducing this new capability (modified TCP header markings for sessions), the irregular codepath is addressed too, such that a 3rd party can not deduct which of the two different paths was sending out the RST, reducing an information side-channel.

rscheff: When a host receives a TCP packet to a port which is not listening, or no connection exists, or…
pauamma_gundo.comUnsubmitted
Done
Inline Actions

Gotcha, thanks. Would "This value also uses ECN for RST replies to probes of non-open ports." mean the same? It looks clearer to me.

pauamma_gundo.com: Gotcha, thanks. Would "This value also uses ECN for RST replies to probes of non-open ports."…
are non-zero, a new key will be automatically generated after this specified are non-zero, a new key will be automatically generated after this specified
seconds. seconds.
The default is 120. The default is 120.
.It Va fastopen.ccache_bucket_limit .It Va fastopen.ccache_bucket_limit
The maximum number of entries in a client cookie cache bucket. The maximum number of entries in a client cookie cache bucket.
The default value can be tuned with the The default value can be tuned with the
.Dv TCP_FASTOPEN_CCACHE_BUCKET_LIMIT_DEFAULT .Dv TCP_FASTOPEN_CCACHE_BUCKET_LIMIT_DEFAULT
kernel option or by setting kernel option or by setting
▲ Show 20 Lines • Show All 201 Lines • ▼ Show 20 Lines
The value of 1 limits the logging to The value of 1 limits the logging to
.Tn SYN .Tn SYN
(connection establishment) packets only. (connection establishment) packets only.
A value of 2 results in any A value of 2 results in any
.Tn TCP .Tn TCP
packets to closed ports being logged. packets to closed ports being logged.
Any value not listed above disables the logging Any value not listed above disables the logging
(default is 0, i.e., the logging is disabled). (default is 0, i.e., the logging is disabled).
.It Va maxtcptw .It Va maxtcptw
When a TCP connection enters the When a TCP connection enters the
.Dv TIME_WAIT .Dv TIME_WAIT
state, its associated socket structure is freed, since it is of state, its associated socket structure is freed, since it is of
negligible size and use, and a new structure is allocated to contain a negligible size and use, and a new structure is allocated to contain a
minimal amount of information necessary for sustaining a connection in minimal amount of information necessary for sustaining a connection in
this state, called the compressed TCP this state, called the compressed TCP
.Dv TIME_WAIT .Dv TIME_WAIT
state. state.
Since this structure is smaller than a socket structure, it can save Since this structure is smaller than a socket structure, it can save
a significant amount of system memory. a significant amount of system memory.
The The
.Va net.inet.tcp.maxtcptw .Va net.inet.tcp.maxtcptw
MIB variable controls the maximum number of these structures allocated. MIB variable controls the maximum number of these structures allocated.
By default, it is initialized to By default, it is initialized to
.Va kern.ipc.maxsockets .Va kern.ipc.maxsockets
/ 5. / 5.
pauamma_gundo.comUnsubmitted
Done
Inline Actions

Was removing this intended as part of this review?

pauamma_gundo.com: Was removing this intended as part of this review?
rscheffAuthorUnsubmitted
Done
Inline Actions

I'm confused, there is no change here on reviews.freebsd.org; it may be that this diff was uploaded just prior to a flurry of tcp related (including man page) changes, which I have not yet rebased the patch to...

rscheff: I'm confused, there is no change here on reviews.freebsd.org; it may be that this diff was…
.It Va minmss .It Va minmss
Minimum TCP Maximum Segment Size; used to prevent a denial of service attack Minimum TCP Maximum Segment Size; used to prevent a denial of service attack
from an unreasonably low MSS. from an unreasonably low MSS.
.It Va msl .It Va msl
The Maximum Segment Lifetime, in milliseconds, for a packet. The Maximum Segment Lifetime, in milliseconds, for a packet.
.It Va mssdflt .It Va mssdflt
The default value used for the TCP Maximum Segment Size The default value used for the TCP Maximum Segment Size
.Pq Dq MSS .Pq Dq MSS
▲ Show 20 Lines • Show All 337 Lines • Show Last 20 Lines