Use shell redirection for gzip invocations.
ClosedPublic
Actions

Authored by delphij on Aug 26 2016, 2:14 AM.

Details

Reviewers

benno
emaste
allanjude
glebius
cperciva

Commits

rS305469: Ensure that we always open only files that is named by explicitly

Summary

Ensure that we always open only files that is named by explicitly
using shell redirections.

This is a superset of D7650.

Issue reported in the "non-cryptanalytic attacks against freebsd
update components" anonymous gist.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4942
Build 5005: arc lint + arc unit

Event Timeline

delphij updated this revision to Diff 19707.Aug 26 2016, 2:14 AM

delphij retitled this revision from to Use shell redirection for gzip invocations..

delphij updated this object.

delphij edited the test plan for this revision. (Show Details)

delphij added reviewers: emaste, cperciva.

Herald added a subscriber: imp. · View Herald TranscriptAug 26 2016, 2:14 AM

delphij added reviewers: glebius, allanjude, benno.Aug 26 2016, 2:15 AM

I like this, it takes away gunzip's ability to ever get it wrong.

This revision is now accepted and ready to land.Aug 26 2016, 2:49 AM

LGTM

Closed by commit rS305469: Ensure that we always open only files that is named by explicitly (authored by delphij). · Explain WhySep 6 2016, 8:52 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.sbin/

portsnap/

portsnap.sh

8 lines

Diff 19707

View Options

usr.sbin/portsnap/portsnap/portsnap.sh

Use shell redirection for gzip invocations.ClosedPublicActions