Forcibly disable MK_TESTS if building without C++
ClosedPublic
Actions

Authored by emaste on Aug 22 2016, 5:15 PM.

Details

Reviewers

ngie
jmmv
bdrewery

Commits

rS304616: Forcibly disable MK_TESTS if building without C++

Summary

Several atf components require C++, and the test suite is not usable if building WITHOUT_CXX.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 19547.Aug 22 2016, 5:15 PM

emaste retitled this revision from to Forcibly disable MK_TESTS if building without C++.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: ngie, jmmv, bdrewery.

Don't forget makegen. I'd let ngie chime in first too.

This revision is now accepted and ready to land.Aug 22 2016, 5:18 PM

Looks good, but it's unfortunate that this is the case.

If I recall correctly, we do not use atf-c++ for any tests in the tree, so the C++ dependency comes from atf-sh's interpreter. The interpreter is pretty simple so it should be relatively easy to rewrite it in C to cut down this dependency. Would you mind filing a feature request in the https://github.com/jmmv/atf/ tracker for this? Thanks.

makegen

Not sure what you mean? I will regenerate src.conf.5 after check-in, of course.

If I recall correctly, we do not use atf-c++ for any tests in the tree, so the C++ dependency comes from atf-sh's interpreter.

I originally tried turning off individual parts of atf, and had to disable lib/atf/libatf-c++ and libexec/atf/{atf-check,atf-sh}. I will submit a feature request, and then disable it for now. I'm not sure how important it is to address this though, since we build with C++ by default, and need C++ for a few base system components.

For background I encountered this while trying to bootstrap lld (LLVM's linker) on FreeBSD/mips64, and lld does not currently cope with some wildcards in libstdc++'s linker script so I'm just trying to build without C++ to make progress on bringup.