Differential D7522

Add fdatasync(2) man page, combined with fsync(2).
ClosedPublic
Actions

Authored by kib on Aug 16 2016, 8:32 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 4, 1:44 PM

	Unknown Object (File)
	Tue, Nov 4, 1:44 PM

	Unknown Object (File)
	Tue, Nov 4, 9:58 AM

	Unknown Object (File)
	Tue, Nov 4, 9:58 AM

	Unknown Object (File)
	Tue, Nov 4, 9:58 AM

	Unknown Object (File)
	Tue, Nov 4, 6:13 AM

	Unknown Object (File)
	Wed, Oct 29, 4:36 AM

	Unknown Object (File)
	Tue, Oct 28, 10:59 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS304287: Add fdatasync(2) man page, combined with fsync(2).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib updated this revision to Diff 19325.Aug 16 2016, 8:32 AM

kib retitled this revision from to Add fdatasync(2) man page, combined with fsync(2)..

kib updated this object.

kib edited the test plan for this revision. (Show Details)

kib added a reviewer: emaste.

kib set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a reviewer: manpages. · View Herald TranscriptAug 16 2016, 8:32 AM

Herald added a subscriber: imp. · View Herald Transcript

emaste added inline comments.Aug 16 2016, 8:50 AM

lib/libc/sys/fsync.2
6	s/was/were/
78–81	Can we be more specific here, or at least avoid "appear"?

Notes by Ed.

Herald edited edge metadata. · View Herald TranscriptAug 16 2016, 9:23 AM

wblock added a subscriber: wblock.Aug 16 2016, 11:48 AM

wblock added inline comments.

lib/libc/sys/fsync.2
78	Passive -> active: If the file metadata has already been committed, using
81	"for the same purpose" is a little unclear. How about can be more efficient than .Fn fsync .
95	Either remove the "The" at the beginning of this sentence, or add a word before "fail" to say what they are: "fsync and fdatasync fail if:" or "The fsync and fdatasync calls fail if:"

wblock changes

Herald edited edge metadata. · View Herald TranscriptAug 16 2016, 2:01 PM

Other than the optional change I suggested for the '.Nd' line, this looks good to me.

lib/libc/sys/fsync.2
42	"synchronize changes to a file's data, without or with it's metadata"

kib added inline comments.Aug 16 2016, 2:47 PM

lib/libc/sys/fsync.2
42	Wouldn't it clutter the tag line ? Some changes are synced, which are is described in the main text. fdatasync(2) cannot be a default choice, it requires careful consideration if used.

emaste accepted this revision.Aug 17 2016, 10:08 AM

emaste edited edge metadata.

emaste added inline comments.

lib/libc/sys/fsync.2
37	Update

This revision is now accepted and ready to land.Aug 17 2016, 10:08 AM

Closed by commit rS304287: Add fdatasync(2) man page, combined with fsync(2). (authored by kib). · Explain WhyAug 17 2016, 10:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

libc/

sys/

1 line

51 lines

Diff 19325

lib/libc/sys/Makefile.inc

Loading...

lib/libc/sys/fsync.2

Loading...