Page MenuHomeFreeBSD
Differential D7499

tcp/lro: Make # of LRO entries tunable
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Aug 15 2016, 2:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 29, 12:05 PM
Unknown Object (File)
Mon, Jun 29, 6:02 AM
Unknown Object (File)
Mon, Jun 15, 1:59 PM
Unknown Object (File)
Mon, Jun 15, 1:48 PM
Unknown Object (File)
May 27 2026, 4:56 PM
Unknown Object (File)
May 18 2026, 4:37 PM
Unknown Object (File)
May 14 2026, 11:38 PM
Unknown Object (File)
May 13 2026, 6:38 PM
View All Files
Subscribers
freebsd-net-list

Details

Reviewers
gallatin
• hselasky
np
rrs
Group Reviewers
transport
Commits
rS304202: tcp/lro: Make # of LRO entries tunable
Summary

Obtained from: rrs, gallatin

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sepherosa_gmail.com updated this revision to Diff 19270.Aug 15 2016, 2:13 AM
sepherosa_gmail.com retitled this revision from to tcp/lro: Make # of LRO entries tunable.
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sepherosa_gmail.com added reviewers: rrs, gallatin, • hselasky, np.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
Herald added a reviewer: transport. · View Herald TranscriptAug 15 2016, 2:13 AM
• hselasky added inline comments.Aug 15 2016, 7:30 AM
sys/netinet/tcp_lro.c
79

Maybe you should use a procedure type and range check the argument.

• hselasky accepted this revision.Aug 15 2016, 7:30 AM
• hselasky edited edge metadata.
gallatin accepted this revision.Aug 15 2016, 6:08 PM
gallatin edited edge metadata.

I tend to think type / range checking something like this is overkill.. I'm OK with it as-is..

Closed by commit rS304202: tcp/lro: Make # of LRO entries tunable (authored by sephe). · Explain WhyAug 16 2016, 6:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
netinet/
12 lines

Diff 19270

View Options

sys/netinet/tcp_lro.c

Loading...