kdump: Use types and constants from amd64 linux32 for Linux on i386
AcceptedPublic
Actions

Authored by jhb on Mon, Nov 9, 6:33 PM.

Project Tags

None

Referenced Files

	F177431578: D61350.1794366071.diff
	Tue, Nov 10, 3:01 AM

	F177423509: D61350.1794347790.diff
	Mon, Nov 9, 9:56 PM

	F177423507: D61350.1794347786.diff
	Mon, Nov 9, 9:56 PM

	F177423487: D61350.1794347750.diff
	Mon, Nov 9, 9:55 PM

	F177420303: D61350.1794337176.diff
	Mon, Nov 9, 6:59 PM

	F177420300: D61350.1794337172.diff
	Mon, Nov 9, 6:59 PM

Subscribers

imp

Details

Reviewers

kib
emaste
imp

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 78895
Build 75778: arc lint + arc unit

Event Timeline

jhb created this revision.Mon, Nov 9, 6:33 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Nov 9, 6:33 PM

jhb requested review of this revision.Mon, Nov 9, 6:33 PM

Harbormaster completed remote builds in B78895: Diff 191998.Mon, Nov 9, 6:33 PM

jhb added a parent revision: D60669: libsysdecode: Use types and constants from amd64 linux32 for Linux on i386.Mon, Nov 9, 6:34 PM

jhb added a child revision: D60670: universe: More gracefully handle architectures without kernels.

kib added inline comments.Tue, Nov 10, 2:04 AM

usr.bin/kdump/linux.c
295	I would move the `(...)` after `#endif` to avoid duplication.

imp accepted this revision.Tue, Nov 10, 2:14 AM

This revision is now accepted and ready to land.Tue, Nov 10, 2:14 AM

Revision Contents
Changeset List

Path

Size

usr.bin/

kdump/

linux.c

12 lines

Diff 191998

View Options

kdump: Use types and constants from amd64 linux32 for Linux on i386AcceptedPublicActions