Paths

Table of Contentst

Differential D60807

bxe: Use __SIZEOF_LONG__ to compute BITS_PER_LONG
AcceptedPublic
Actions

Authored by jhb on Sat, Oct 17, 4:22 PM.

Project Tags

None

Referenced Files

	F177459993: D60807.1794464986.diff
	Wed, Nov 11, 6:29 AM

Subscribers

Details

Reviewers

kib
imp

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 78296
Build 75179: arc lint + arc unit

Event Timeline

jhb created this revision.Sat, Oct 17, 4:22 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Oct 17, 4:22 PM

jhb requested review of this revision.Sat, Oct 17, 4:22 PM

jhb added a parent revision: D60806: padlock: Remove architecture #ifdefs.

Harbormaster completed remote builds in B78296: Diff 190113.Sat, Oct 17, 4:22 PM

jhb added a child revision: D60668: sys: Use armv7 instead of i386 for 32-bit KBI assertions.Sat, Oct 17, 4:23 PM

kib added inline comments.Sat, Oct 17, 6:23 PM

sys/dev/bxe/bxe_stats.c
33	It can be `sizeof(long) * CHAR_BIT` and use only standard C.

jhb added inline comments.Mon, Oct 19, 5:10 PM

sys/dev/bxe/bxe_stats.c
33	We already use `__SIZEOF_LONG__` elsewhere, though there is also `__CHAR_BIT__` when this is used in the LinuxKPI bitops.h. Looks like some place also use `sizeof(long)` and also use `NBBY`.

imp accepted this revision.Mon, Oct 19, 5:15 PM

imp added inline comments.

sys/dev/bxe/bxe_stats.c
33	I thought we were generally standardizing on SIZEOF_LONG since it's on all compilers we can build the kernel with for a while now. And it can be trivially be provided in the build glue for people porting. (rather than having to play whack-a-mole with all the other symbols).

This revision is now accepted and ready to land.Mon, Oct 19, 5:15 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

bxe/

6 lines

Diff 190113

sys/dev/bxe/bxe_stats.c

Loading...