Page MenuHomeFreeBSD
Differential D7428

Correct function prototype for STAILQ_SWAP in manpage
ClosedPublic
Actions

Authored by akshay1994.leo_gmail.com on Aug 6 2016, 10:16 AM.
Tags
None
Referenced Files
F107199733: D7428.diff
Sat, Jan 11, 1:51 PM
Unknown Object (File)
Dec 10 2024, 11:06 AM
Unknown Object (File)
Dec 6 2024, 5:32 AM
Unknown Object (File)
Nov 26 2024, 4:10 PM
Unknown Object (File)
Oct 18 2024, 12:20 AM
Unknown Object (File)
Oct 1 2024, 3:08 PM
Unknown Object (File)
Sep 27 2024, 6:46 PM
Unknown Object (File)
Sep 18 2024, 12:07 PM
View All 75 Files
Subscribers
bjk
imp
pfg
royger
wblock
Contributor Reviews (src)

Details

Reviewers
wblock
Group Reviewers
manpages
Commits
rS303801: Correct the documentation of the 'type' parameter for the _SWAP
Summary

Refer https://github.com/freebsd/freebsd/blob/af3e10e5a78d3af8cef6088748978c6c612757f0/sys/sys/queue.h#L379

Test Plan

NA

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

akshay1994.leo_gmail.com updated this revision to Diff 19085.Aug 6 2016, 10:16 AM
akshay1994.leo_gmail.com retitled this revision from to Correct function prototype for STAILQ_SWAP in manpage.
akshay1994.leo_gmail.com updated this object.
akshay1994.leo_gmail.com edited the test plan for this revision. (Show Details)
akshay1994.leo_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a reviewer: manpages. · View Herald TranscriptAug 6 2016, 10:16 AM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
akshay1994.leo_gmail.com edited edge metadata.Aug 6 2016, 10:17 AM
akshay1994.leo_gmail.com added subscribers: pfg, royger.
wblock accepted this revision.Aug 6 2016, 10:40 AM
wblock added a reviewer: wblock.
wblock added a subscriber: wblock.

Looks okay to me (correcting a cut-and-paste error). Next time, a little bit of explanation in the Details section of the review would help to explain not just what is being done, but why.

This revision is now accepted and ready to land.Aug 6 2016, 10:40 AM
Closed by commit rS303801: Correct the documentation of the 'type' parameter for the _SWAP (authored by bjk). · Explain WhyAug 6 2016, 5:27 PM
This revision was automatically updated to reflect the committed changes.
akshay1994.leo_gmail.com edited edge metadata.Aug 6 2016, 5:34 PM
akshay1994.leo_gmail.com added a subscriber: bjk.
akshay1994.leo_gmail.com added a comment.Aug 6 2016, 5:37 PM

Hi bjk,

Only the Prototypes for SLIST and STAILQ were wrong.
LIST and TAILQ do require "LIST_ENTRY NAME" and "TAILQ_ENTRY NAME", respectively.

Refer: https://github.com/freebsd/freebsd/blob/master/sys/sys/queue.h#L523
and
https://github.com/freebsd/freebsd/blob/master/sys/sys/queue.h#L736

bjk added a comment.Aug 6 2016, 7:41 PM
In D7428#154575, @akshay1994.leo_gmail.com wrote:

Hi bjk,

Only the Prototypes for SLIST and STAILQ were wrong.
LIST and TAILQ do require "LIST_ENTRY NAME" and "TAILQ_ENTRY NAME", respectively.

Thanks for pointing it out; I must have been looking at the SLIST one in queue.h by accident while I was checking. Should be fixed in r303805

Revision Contents
Changeset List

PathSize
head/
share/
man/
man3/
8 lines

Diff 19096

View Options

head/share/man/man3/queue.3

Loading...