Page MenuHomeFreeBSD
Differential D60564

libpmc, pmcstat: harden multipart sample consumers
Needs ReviewPublic
Actions

Authored by afscoelho_gmail.com on Sat, Oct 10, 1:22 AM.
Tags
None
Referenced Files
F176585646: D60564.diff
Tue, Oct 20, 1:00 AM
F176555402: D60564.id189843.diff
Mon, Oct 19, 7:42 PM
F176510704: D60564.id189319.diff
Mon, Oct 19, 10:38 AM
Unknown Object (File)
Mon, Oct 19, 1:21 AM
Unknown Object (File)
Sun, Oct 18, 11:27 PM
Unknown Object (File)
Sun, Oct 18, 8:52 PM
Unknown Object (File)
Sun, Oct 18, 8:38 PM
Unknown Object (File)
Sun, Oct 18, 5:17 PM
View All 26 Files
Subscribers
imp
ziaee

Details

Reviewers
mhorne
gnn
ali_mashtizadeh.com
Group Reviewers
pmc
Summary

Skip the multipart header and payload when reading callchains, and
check record lengths before use. Add ATF tests.

Depends on D60563

Test Plan

Built amd64 GENERIC + hwpmc.ko, GENERIC without HWPMC_HOOKS, and arm64.
Ran tests/sys/pmc on AMD Zen 6 (LBR v2).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 78195
Build 75078: arc lint + arc unit

Revision Contents
Changeset List

PathSize
lib/
libpmc/
17 lines
3 lines
15 lines
libpmcstat/
23 lines
tests/
sys/
pmc/
1 line
315 lines
usr.sbin/
pmcstat/
43 lines

Diff 189843

View Options

lib/libpmc/libpmc_json.cc

Loading...
View Options

lib/libpmc/pmc.ibs.3

Loading...
View Options

lib/libpmc/pmclog.c

Loading...
View Options

lib/libpmcstat/libpmcstat_logging.c

Loading...
View Options

tests/sys/pmc/Makefile

Loading...
View Options

tests/sys/pmc/pmc_multipart_test.c

Loading...
View Options

usr.sbin/pmcstat/pmcstat_log.c

Loading...