Update the sysbench port to build from https://github.com/akopytov/sysbench . Tests are now written in lua and the port has been updated to reflect that.
Details
Details
- Reviewers
editor_callfortesting.org kmoore mat matthew dvl - Group Reviewers
Contributor Reviewers (ports) - Commits
- rP441537: Update the sysbench port to build from
Test inside poudriere
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
The original sysbench author promised an updated release but may have abandoned the project. Percona has forked it for their purposes. Other suggestions in this situation?
| Makefile | ||
|---|---|---|
| 16 | This is the default and should be removed. | |
| 36 | Remove && cd - ? Also, isn't autogen.sh doing about the same thing as USES=autoreconf ? | |
| 42 | Does this have to be pre-install ? if it is not needed for do-install to work, it should be post-install. | |
| 44 | Don't use cp -r, use the COPYTREE_* macros. https://www.freebsd.org/doc/en/books/porters-handbook/install.html | |
Comment Actions
If there aren't anymore changes needed, what is the best way to get in touch with a ports committer?
Comment Actions
Is there a PR for this?
Hmmm.... I can't seem to apply this patch to my ports tree.
lucid-nonsense:~...ports/benchmarks/sysbench:% arc patch D7388 A files Exception Command failed with error #1! COMMAND (cd '/home/matthew/work/ports/' && mkdir 'files') STDOUT (empty) STDERR mkdir: files: File exists (Run with `--trace` for a full exception trace.)
Comment Actions
Having plumbed the mysteries of 'Download Raw Diff' I can run test builds. Seems all of mat's points have been addressed. Looks good to me
Comment Actions
I've checked the upstream and found that 1.0.7 is released. Would you please update the patch to the latest release? Thanks!
BTW, do you want to take maintainership?
| Makefile | ||
|---|---|---|
| 16 | GH_TAGNAME can be removed if you update it to 1.0.7. | |
| files/patch-autogen.sh | ||
| 6 | I would suggest using USES=shebangfix and bash_CMD=/bin/sh instead. | |
Comment Actions
Upgrading to the 1.0 branch is non-trivial -- I'll take another crack at it if I have time.